Using multi-release modules fails with base version

[mdreier-sap]

This is a follow-up to #141. The solution in #147 only works for numeric version numbers. However, according to the jdeps documentation, the value base is also valid.

The value is parsed in JdepsExtraArgsExtractor.parseVersionNumber().

Reproduction:

<plugin>
    <groupId>org.moditect</groupId>
    <artifactId>moditect-maven-plugin</artifactId>
    <version>1.0.0.RC2</version>
    <configuration>
        <modules><!-- ... --></modules>
        <jdepsExtraArgs>
            <jdepsExtraArg>--multi-release</jdepsExtraArg>
            <jdepsExtraArg>base</jdepsExtraArg>
        </jdepsExtraArgs>
    <configuration>
</plugin>

Error message:

[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info (add-module-infos) on project redacted: Execution add-module-infos of goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info failed: Couldn't parse C:\redacted\target\moditect\dependency\module-info.java -> [Help 1]

[gunnarmorling]

Interesting, that was news to me. Could you send a PR for fixing this?

[mdreier-sap]

Sure, but might be some time before I get around to it. Anyone willing to contribute is welcome to do so.

[yrodiere]

I'm not sure how to reproduce this problem.

A far as I can see, the current code will log an error, but it will carry on and interpret base as "the module-info.java is at the root and not in the versions/<some-version> directory":

moditect/core/src/main/java/org/moditect/internal/parser/JdepsExtraArgsExtractor.java

Lines 74 to 79 in d2cc464

	try {
	return Optional.of(Integer.parseInt(versionString));
	} catch (NumberFormatException ex) {
	error("Invalid argument value for " + MULTI_RELEASE_ARGUMENT + ": " + versionString);
	return Optional.empty();
	}

That's the behavior we can see in your error message, btw:

Couldn't parse C:\redacted\target\moditect\dependency\module-info.java

But as far as I can see, jdeps is supposed to interpret base the same way:

• https://github.com/openjdk/jdk/blob/5740a3b6e635456b34b4f31d0f1e84d3e746b796/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java#L274-L275
• https://github.com/openjdk/jdk/blob/5740a3b6e635456b34b4f31d0f1e84d3e746b796/src/java.base/share/classes/java/util/jar/JarFile.java#L179
• https://github.com/openjdk/jdk/blob/5740a3b6e635456b34b4f31d0f1e84d3e746b796/src/java.base/share/classes/java/util/jar/JarFile.java#L604

So, I really don't understand what's going on in your case. Maybe my PR #163 will fix this, but I doubt it. In any case, if the problem persists, a reproducer would help, so we can find out where module-info.java actually is in your case.