Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sample_n() with slice_sample() #396

Open
ismayc opened this issue Jul 15, 2020 · 2 comments
Open

Replace sample_n() with slice_sample() #396

ismayc opened this issue Jul 15, 2020 · 2 comments
Assignees
Labels
v2 Second edition

Comments

@ismayc
Copy link
Member

ismayc commented Jul 15, 2020

https://dplyr.tidyverse.org/reference/sample_n.html

@ismayc ismayc added the v2 Second edition label Jul 15, 2020
@rudeboybert
Copy link
Member

Note from @ismayc: Simon has implemented a rep_slice_sample() function in {infer} that should be merged in soon: https://github.com/tidymodels/infer/pull/362/files. Might be best to add a reminder to convert all the rep_sample_n() over when the next version of {infer} goes to CRAN.

@rudeboybert rudeboybert self-assigned this Feb 8, 2021
@ismayc
Copy link
Member Author

ismayc commented Apr 3, 2023

@avaldivi6 Just remembered this. sample_n() has been superseded by slice_sample(), so we should switch it and also rep_sample_n() over to rep_slice_sample().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Second edition
Projects
None yet
Development

No branches or pull requests

2 participants