Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed major edits in v2 #418

Merged
merged 34 commits into from
Feb 8, 2021
Merged

Proposed major edits in v2 #418

merged 34 commits into from
Feb 8, 2021

Conversation

rudeboybert
Copy link
Member

@rudeboybert rudeboybert commented Jan 30, 2021 •
edited

Proposed major edits in v2:

  • Chapter 6 Multiple Regression: Split "6.3.1 Model selection" into:
    • "6.3.1 Model selection using visualizations"
    • Added "6.3.2 Model selection using R-squared"
  • Chapter 7 Sampling: Refactored as follows
    • "7.3.1 Terminology & notation": clustered definitions according to theme and connected back to sampling exercises
    • "7.3.2 Statistical definitions":
    • Moved "7.5.2 Central Limit Theorem" to its own section to make it more prominent and not an after-thought

rudeboybert and others added 25 commits February 26, 2020 07:53
@rudeboybert
Merge pull request #297 from moderndive/master
72c8bfe 
Update bert-dev branch
@rudeboybert
Merge pull request #298 from moderndive/master
17dd488 
Added tips & tricks to bert-dev
@rudeboybert
Merge pull request #300 from moderndive/master
95297cf 
Fixes #299
@rudeboybert
legend
e5817a8
@rudeboybert
Merge pull request #303 from moderndive/master
d2f815b 
Updating bert-dev
@rudeboybert
Done MVP of R-squared
fc4621d
@rudeboybert
typos
a30ddd3
@rudeboybert
Revert bookdown
9fd4eaa
@rudeboybert
typo
17317c4
@rudeboybert
Added list of sections in data wrangling appendix
96e432c
@wjhopper
Correct model name in learning check 6.1
d4365b5 
The text of learning check 6.1 refers to computing predictions for a parallel slope model, but refers to an R object named score_model_interaction, which is actually an independent slopes model.
@wjhopper
Merge pull request #1 from wjhopper/wjhopper-dev
505b082 
Correct model name in learning check 6.1
@rudeboybert
Merge pull request #318 from wjhopper/master
869287e 
Correct model name in Learning Check 6.1
@rudeboybert
typos
124fe80
@rudeboybert
Cleaned NEWS.md
6964612
@rudeboybert
Word-smithing introduction of terminology, notation, & definitions
f2fee03
@rudeboybert
Removed any hard-coding of prop red related values
781602d
@rudeboybert
More refactoring
00d29fa
@rudeboybert
Done MVP of refactoring
2522ba5
@rudeboybert
Merge pull request #324 from moderndive/refactor-sampling
78ca525 
Refactoring Ch7 sampling
@rudeboybert
Merge branch 'master' into bert-dev
8ff023d
@rudeboybert
Starting CLT edits
157a6ab
@kmkinnaird
Switched section ordering and added to CLT
5b207e5 
Switched poll example and CLT ordering. Added to framing of CLT.
@rudeboybert
minor polishes
a03b151
@rudeboybert
Merge pull request #326 from moderndive/kmkinnaird-CLT-edits
cec49eb 
Switched section ordering and added to CLT
@rudeboybert rudeboybert linked an issue Jan 30, 2021 that may be closed by this pull request
Refactor sampling framework 7.3 #342
Closed
This was linked to issues Jan 30, 2021
Move CLT to its own Ch7 section #341
Closed
R-squared and R-squared adjusted #296
Closed
Potential improvements for v2 #366
Open
@rudeboybert rudeboybert changed the title Tentative v2 changes to multiple regression and sampling chapters Proposed major edits in v2 Jan 30, 2021
@rudeboybert
Copy link
Member Author

rudeboybert commented Jan 30, 2021 •
edited

Still need to:

  • Do a close read of R-squared adjusted chapters
  • Do a close read of sampling chapter to make sure nothing got lost in merge
  • Run refactoring on new code like Marium did

This was unlinked from issues Jan 30, 2021
Move CLT to its own Ch7 section #341
Closed
Refactor sampling framework 7.3 #342
Closed
@ismayc ismayc self-requested a review February 5, 2021 21:11
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
06-multiple-regression.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
07-sampling.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
07-sampling.Rmd Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
07-sampling.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc reviewed Feb 7, 2021
View reviewed changes
07-sampling.Rmd Outdated Show resolved Hide resolved
ismayc
ismayc requested changes Feb 7, 2021
View reviewed changes
Copy link
Member

@ismayc ismayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to tweak and suggestions. Looks good though!

rudeboybert and others added 3 commits February 7, 2021 20:28
@rudeboybert @ismayc
Apply suggestions from code review
59a0815 
Co-authored-by: Chester Ismay <chester.ismay@gmail.com>
@rudeboybert
removed hard-coded values
150e2c8
@rudeboybert @ismayc
Apply suggestions from code review
823dbee 
Co-authored-by: Chester Ismay <chester.ismay@gmail.com>
@rudeboybert
Copy link
Member Author

Thanks @ismayc! I'll file a new issue regarding rep_slice_sample()

@rudeboybert rudeboybert merged commit ed09c4a into v2 Feb 8, 2021
@rudeboybert rudeboybert deleted the refactor-sampling branch February 8, 2021 01:47
@rudeboybert rudeboybert mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismayc ismayc ismayc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential improvements for v2 R-squared and R-squared adjusted
4 participants
@rudeboybert @ismayc @wjhopper @kmkinnaird