Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle folders #1188 #1323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

santiagocarod
Copy link

@santiagocarod santiagocarod commented Feb 26, 2024

Technical implementation details

Create a new item on the folder menu for the toggle of the complete folder.

Screen Recording 2024-02-26 at 3 57 50 PM

Checklist

  • data migration added (@mockoon/commons)
  • commons lib tests added (@mockoon/commons)
  • commons-server lib tests added (@mockoon/commons-server)
  • CLI tests added (@mockoon/cli)
  • desktop UI automated tests added (@mockoon/desktop)

Closes #1188

@santiagocarod santiagocarod changed the title Toggle all direct children from folder #1188 Toggle folders #1188 Feb 26, 2024
Copy link
Member

@255kb 255kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
I plan to release v7.0.0 on Monday. It's a small feature and it could make it for the release.
Do you still plan to add an red indicator on the folder too like discussed in the issue?

action: 'toggle',
subjectUUID: folderUUID
},
label: 'Toggle folder',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you edit the label for something more precise, like:

Suggested change
label: 'Toggle folder',
label: 'Toggle direct child routes',

@255kb
Copy link
Member

255kb commented Apr 24, 2024

@santiagocarod next release is coming soon. Let me know if you have time to finalize this PR or if you need anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle Folders with Routes
2 participants