Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Question: GitHub release provider for Travis needed? #867

Open
beatngu13 opened this issue Mar 7, 2020 · 1 comment
Open

Question: GitHub release provider for Travis needed? #867

beatngu13 opened this issue Mar 7, 2020 · 1 comment
Labels

Comments

@beatngu13
Copy link

beatngu13 commented Mar 7, 2020

Hi folks!

I'm a contributor to JUnit Pioneer (which uses Shipkit) and some time ago I've opened this PR adding a GitHub release provider to the Travis config because releases haven't been marked properly (see v0.3.2).

I'm not very familiar with Shipkit, but while the PR was open, Shipkit suddenly created proper releases (see v0.3.3). Maybe this was due to a misconfiguration of Shipkit on Pioneer's behalf, but we merged the PR anyway.

Recently I realized that the GitHub release provider is never triggered due to Shipkit's CI skip when committing the release tag, so I've opened this issue. I just wonder what is the "Shipkit way" of doing this?

If, for example, I want to add additional artifacts to the GitHub release (e.g. JARs), should this be done with a GitHub release provider for Travis and then prevent Shipkit from skipping the CI build? Or is the release provider not needed at all?

Thank you in advance! 🙏

@aepfli
Copy link

aepfli commented Mar 30, 2020

relates to #843

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants