You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mobx currently fails to work with spec-compliant decorators (in swc) when using @action x = () => {}.
The reason this issue is hard to see is that apparently both tsc and babel do not follow the decorator spec, while swc does. I've opened an issue with typescript as well microsoft/TypeScript#57096 because both their code as well as the types seem to conflict with the spec.
In any case, this change works both with tsc and with swc (and I assume babel as well).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Yeah the spec changed a few times in this regard through the different stages. Things is probably ok, but there is a build failure prevent the tests to run, mind updating? (seems just removing an unused variable which our config is being too sensitive about)
This was a result of the readme of the spec text being wrong / outdated. I've fixed it in swc here: swc-project/swc#8525 and the spec text has also been fixed, so this is no longer necessary (afaik)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3817 .
Mobx currently fails to work with spec-compliant decorators (in swc) when using
@action x = () => {}.The reason this issue is hard to see is that apparently both tsc and babel do not follow the decorator spec, while swc does. I've opened an issue with typescript as well microsoft/TypeScript#57096 because both their code as well as the types seem to conflict with the spec.
In any case, this change works both with tsc and with swc (and I assume babel as well).