New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle 1xx messages properly #186

Open

reschke opened this issue Nov 16, 2016 · 5 comments

Labels

Contributor

reschke commented Nov 16, 2016

Example: https://redbot.org/?uri=https%3A%2F%2Fnghttp2.org%2F%3F103-eh

Seems redbot is taking the 103 as final responses and waits the socket to be closed as there is no Content-Length information.

Owner

mnot commented Nov 16, 2016

Have it working, roughed in like this:

Owner

mnot commented Nov 16, 2016 •

edited

Open questions:

Get it into HAR, TXT output
Make sure Notes are going to the right destination
options line (e.g., response header size) after each? Or aggregate?
separate notes out for each response?
see what body on 1xx looks like.

Contributor Author

reschke commented Nov 16, 2016

Looks good.

How would you have a body on 1xx, though?

Owner

mnot commented Nov 16, 2016

I want to make sure it calls this out as an error in a good way.

Contributor Author

reschke commented Nov 16, 2016

Ack.

mnot added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment