Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/thirdparty: standard library tests are slow #260

Open
mmcloughlin opened this issue Apr 24, 2022 · 1 comment
Open

tests/thirdparty: standard library tests are slow #260

mmcloughlin opened this issue Apr 24, 2022 · 1 comment
Labels
cleanup General cleanup and code health testing Tests and supporting infrastructure

Comments

@mmcloughlin
Copy link
Owner

#225 and #226 added third-party tests for crypto/ed25519. However, this test is slow, largely due to having to run make.bash to compile the Go toolchain.

It would be good to fix this. See #226 for some ideas. Perhaps the best way to do this would be to allow the "checkout" phase of the test to be customizable, allowing this particular test to use a pre-compiled Go distribution rather than a fresh git checkout.

@mmcloughlin mmcloughlin added testing Tests and supporting infrastructure cleanup General cleanup and code health labels Apr 24, 2022
@mmcloughlin mmcloughlin changed the title tests/thirdparty: crypto/ed25519 test is slow tests/thirdparty: standard library tests are slow Jan 14, 2023
@mmcloughlin
Copy link
Owner Author

#355 has the same problem, so now this issue is twice as bad.

If we can't fix the root cause, you could imagine restructuring it so that the two stdlib tests share a common setup step, and the make.bash is run only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup General cleanup and code health testing Tests and supporting infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant