Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build/script script names in electron #35

Open
whenmoon opened this issue Dec 1, 2021 · 5 comments
Open

Fix build/script script names in electron #35

whenmoon opened this issue Dec 1, 2021 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@whenmoon
Copy link

whenmoon commented Dec 1, 2021

When I run yarn electron:package:mac I get the error "Command "build" not found". When I update the packages/electron package.json script to remove yarn build from the "package:mac" script, electron build throws the error: "Application entry file "build/electron.js in Contents/Resources/app.asar" does not exist".

Is there a way to resolve this? Thanks.
@whenmoon whenmoon changed the title yarn electron:package:mac - error Command "build" not found yarn electron: package: mac - error Command "build" not found Dec 1, 2021
@whenmoon
Copy link
Author

whenmoon commented Dec 1, 2021

Ok solved the latter issue by running the cra:build script first.

@mmazzarolo
Copy link
Owner

Ha! @whenmoon this is actually a bug, good call — these two commands should probably drop the cra: prefix.

@mmazzarolo mmazzarolo changed the title yarn electron: package: mac - error Command "build" not found Fix build/script script names in electron Dec 2, 2021
@mmazzarolo mmazzarolo added bug Something isn't working good first issue Good for newcomers labels Dec 2, 2021
@whenmoon
Copy link
Author

whenmoon commented Dec 2, 2021

Hi @mmazzarolo, ok , I'll open a PR to fix..

@WayneKim92
Copy link

Remove cra: prefix and then remevoe ^ at devDependencies of electron. like that ^14.0.0 -> 14.0.0

code4break added a commit to code4break/react-native-universal-monorepo that referenced this issue May 29, 2022
@code4break
mmazzarolo#35 Changed script name
8506d3b
code4break added a commit to code4break/react-native-universal-monorepo that referenced this issue May 29, 2022
@code4break
mmazzarolo#35 Changed electron version prefix. [Thanks to] (mmazzarol…
226c163 
…o#35 (comment)) @WayneKim92
@code4break code4break mentioned this issue May 29, 2022
Merged
@code4break
Copy link
Contributor

In my opinion, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mmazzarolo @code4break @whenmoon @WayneKim92