Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FocusSearch doesn't handle discrete vector parameters #201

Open
mb706 opened this issue Mar 5, 2016 · 4 comments
Open

FocusSearch doesn't handle discrete vector parameters #201

mb706 opened this issue Mar 5, 2016 · 4 comments
Assignees

Comments

@mb706
Copy link
Contributor

mb706 commented Mar 5, 2016

In particular, I reliably get an error here when I have a discrete vector parameter, since val is a list and setdiff(val.names, val) can make val.names empty even when it was length(par$values) > 1L before.

Should I, in general, assume that mlrMBO wasn't designed to handle vector parameters and give up right now, or is this worth a fix?

@mb706 mb706 changed the title FocusSearch doesn't handle vector parameters FocusSearch doesn't handle discrete vector parameters Mar 5, 2016
@mb706
Copy link
Contributor Author

mb706 commented Mar 5, 2016

Addendum: this is a bug anyway since to.del is a number and always ranges from 1 to length(par$values) - 1, no matter what val was.

mb706 pushed a commit to mb706/mlrMBO that referenced this issue Mar 5, 2016
@mb706
Copy link
Contributor Author

mb706 commented Mar 7, 2016

As commented in PR #202, infillOptFocus cannot, in principle, handle parameters that have requirements depending on discrete vector parameters. One would need to either adapt something in ParamHelpers or automatically rewrite the requirements and decompose vector params into scalar params. This is a bit tricky, but I've done something similar here with the help of this function.

@jakobbossek
Copy link
Contributor

jakobbossek commented Sep 18, 2016

@berndbischl Please review PR #202 PR #257

@jakobbossek
Copy link
Contributor

@berndbischl: ping

berndbischl pushed a commit that referenced this issue Nov 18, 2016
ja-thomas pushed a commit that referenced this issue Nov 24, 2016
ja-thomas pushed a commit that referenced this issue Nov 30, 2016
berndbischl pushed a commit that referenced this issue Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants