Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_task_*_st and friends could allow setting column roles directly #184

Open
pat-s opened this issue May 26, 2022 · 2 comments
Open

as_task_*_st and friends could allow setting column roles directly #184

pat-s opened this issue May 26, 2022 · 2 comments

Comments

@pat-s
Copy link
Member

pat-s commented May 26, 2022

We could support this via the ellipsis. Otherwise setting the respective column roles could be somewhat easily forgotten.
On the other hand behaviour would differ than compared to as_task_*() from mlr3 as such custom conversions would not be supported there.

@be-marc what do you think?

Example:

data("cookfarm_sample", package = "mlr3spatiotempcv")

# data.frame
as_task_regr_st(cookfarm_sample, target = "PHIHOX",
  coords_as_features = FALSE,
  crs = 26911,
  coordinate_names = c("x", "y"),
  column_role_space = "foo",
  column_role_time = "time"
)

```
@pat-s
Copy link
Member Author

pat-s commented Jun 4, 2022

Thinking about it once more, I guess leaving it as it is might be best.
This change would also be very niche and the behavior does not appear in other mlr3 packages, so it would probably not be used much.

@pat-s pat-s closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2022
@pat-s pat-s reopened this Jun 7, 2022
@pat-s
Copy link
Member Author

pat-s commented Jun 7, 2022

With *ST tasks becoming the main Task type (again), we probably want to have this. Maybe not with space and time col roles but groups instead - but the general feature to specify the grouping during task construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant