Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback learner should maybe be a warning #972

Open
sebffischer opened this issue Nov 22, 2023 · 1 comment
Open

fallback learner should maybe be a warning #972

sebffischer opened this issue Nov 22, 2023 · 1 comment

Comments

@sebffischer
Copy link
Sponsor Member

Currently, the fallback learner log info is only shown during debug mode:

mlr3/R/worker.R

Lines 94 to 102 in dc2a983

lg$debug("Calling train method of fallback '%s' on task '%s' with %i observations",
fb$id, task$id, task$nrow, learner = fb$clone())
fb = assert_learner(as_learner(fb))
require_namespaces(fb$packages)
fb$train(task)
learner$state$fallback_state = fb$state
lg$debug("Fitted fallback learner '%s'",

maybe this should be a warning?

@mb706
Copy link
Collaborator

mb706 commented Mar 26, 2024

Maybe relates more to the 'encapsulate' machinery than the fallback learner -- what to do if something that was encapsulated fails? Or is there a way for the fallback learner to be invoked without the encapsulation noticing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants