Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making BLAS thread setting optional, RhpcBLASctl Suggests #1023

Open
MichaelChirico opened this issue May 6, 2024 · 0 comments
Open

Comments

@MichaelChirico
Copy link
Contributor

MichaelChirico commented May 6, 2024

Follow-up to 959c9d6.

{RhpcBLASctl} is AGPL-licensed -- that makes it unattractive for many reasons, e.g.

https://opencoreventures.com/blog/2023-10-agpl-license-is-a-non-starter-for-most-companies/
https://deavid.wordpress.com/2020/08/02/affero-gpl-is-toxic-avoid-it-like-the-plague/
https://opensource.google/documentation/reference/using/agpl-policy

By having {RhpcBLASctl} in Imports, that means {mlr3} also can't be used without patching to avoid the AGPL dependency.

Glancing at the codebase, I think we can reasonably move that code to set BLAS threads as optional, and thereby relegate {RhpcBLASctl} to a Suggests dependency. WDYT?

Happy to file the relevant PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant