Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to adopt the latest jupyterhub feature #25

Open
comeUpWithItLater opened this issue Jul 28, 2021 · 2 comments
Open

upgrade to adopt the latest jupyterhub feature #25

comeUpWithItLater opened this issue Jul 28, 2021 · 2 comments
Labels
feature-request Request for a new feature

Comments

@comeUpWithItLater
Copy link

Feature description:

Upgrade the helm chart to adopt the latest feature that jupyterhub offer , such as Customizing User Storage

Problem and motivation:

This will ensure that the latest feature in jupyterhub is always available in ml-hub.

Is this something you're interested in working on?

Yes, l'd love to . But I need some guideline on where to start.

@comeUpWithItLater comeUpWithItLater added the feature-request Request for a new feature label Jul 28, 2021
@ClementGautier
Copy link
Contributor

I was going to make some changes in the helm chart but saw that most of what I'm trying to solve is already fixed in https://github.com/jupyterhub/zero-to-jupyterhub-k8s/tree/main/jupyterhub

@raethlein : would you consider removing all jupyterhub related things from this repository and use the helm chart from jupyterhub as dependency?

@raethlein
Copy link
Member

raethlein commented Dec 23, 2021

Hey @comeUpWithItLater and @ClementGautier, thanks for looking into this!
I think using the official jupyterhub helm chart would be great as this would be one less dependency to care about. Back then I think the decision to copy the helm chart / parts of it to this repo was that we needed to make some slight modifications (e.g. setting some environment variables, opening another port for ssh access etc.) that was not directly configurable in the jupyterhub helm chart. I have to look into the newest helm chart version to see whether it could not be easily configured without the need to copy it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants