Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary: Small Fixes for standardization naming, order etc- no_impact, skipped, etc #2077

Open
aaronlippold opened this issue Dec 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aaronlippold
Copy link
Member

Current

We should standardize our naming conventions for the tools, input files, across the SAF and CLI.

I also put thing in a standard order of:

Total
Critical
H
M
L
None

Swapped Profile Error and Not Applicable as it seems more logical.

With the change we should also make sure we are backwards compat and that we also update the generate function for thresholds to use the new labels.

- profileName: aws-foundations-cis-baseline
  resultSets:
    - inspec_results.json
  compliance: 7
  passed:
    critical: 0
    high: 0
    medium: 4
    low: 0
    total: 4
  failed:
    critical: 0
    high: 0
    medium: 39
    low: 0
    total: 39
  skipped:
    critical: 0
    high: 0
    medium: 17
    low: 0
    total: 17
  error:
    critical: 0
    high: 0
    medium: 0
    low: 0
    total: 0
  no_impact:
    none: 4
    total: 4

Expected

- profileName: aws-foundations-cis-baseline
  resultSets:
    - inspec_results.json
  compliance: 7
  passed:
    total: 4
    critical: 0
    high: 0
    medium: 4
    low: 0
  failed:
    total: 39
    critical: 0
    high: 0
    medium: 39
    low: 0
  not_reviewed:
    total: 4   
    critical: 0
    high: 0
    medium: 17
    low: 0
  not_applicable:
    total: 4     
    none: 4 
  profile_error:
    total: 0
    critical: 0
    high: 0
    medium: 0
    low: 0
@aaronlippold aaronlippold added the enhancement New feature or request label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants