Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "saf supplement tag" command #1293

Open
ejaronne opened this issue Apr 5, 2023 · 3 comments · May be fixed by #1381
Open

add "saf supplement tag" command #1293

ejaronne opened this issue Apr 5, 2023 · 3 comments · May be fixed by #1381
Assignees
@Amndeep7

Comments

@ejaronne
Copy link
Contributor

ejaronne commented Apr 5, 2023

Develop "saf supplement tag -i <current-hdf-file.json> -m <existing-to-new_tag_mapping_file> -e <existing tag key name> -n <new tag key name> -o <output-hdf-file.json>"
command to the SAF CLI to add tags based on existing tags within an HDF results file.
The mapping file is a two-column csv or json. Header dictates the existing tag name and new tag name as keys for matching/adding.

(will follow-up with sample csv)
@Amndeep7
Copy link
Contributor

Amndeep7 commented Apr 6, 2023 •
edited

old_name (optional), new_name (optional), value for tag (optional)
nist, cool_nist,,
,cci, 123123123,
existingtag,,new_value

tag extender concept
column-header-existing-tag,column-header-new-tag,maybe-other-column
possible-existing-tag-value,value-for-new-tag

outta the gate csv before json

ok to overwrite values

handle arrays for the input (so if input array is cci and there is cci-1 and cci-2, then we get the results for both in output tag array)

duplicate values in output array is fine

default is for all controls, but maybe option to specify which controls in particular

@aaronlippold
Copy link
Member

This would also make sense for the profile itself as well - I think we outlined this came feature request before. I will see if I can find it

@aaronlippold
Copy link
Member

Updating the results data only would lead very quickly to fixing the issue at the source

@GavMason GavMason linked a pull request May 8, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amndeep7 Amndeep7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supplement tags mitre/saf
3 participants
@aaronlippold @Amndeep7 @ejaronne