Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code for Google Drive integration #154

Open
randi-c-dubs opened this issue Aug 29, 2022 · 1 comment
Open

Cleanup code for Google Drive integration #154

randi-c-dubs opened this issue Aug 29, 2022 · 1 comment
Assignees
@mewtaylor @randi-c-dubs @pmalacho-mit

Comments

@randi-c-dubs
Copy link
Collaborator

randi-c-dubs commented Aug 29, 2022 •
edited

Work should be done to make the Google Drive integration code cleaner and more modular:

  1. OAuth code in menu-bar.jsx and google-drive-picker.jsx is redundant. Create a separate file/folder within scratch-gui/src/components that handles all OAuth logging in
  2. Finish migrating to the new Google auth flow ; https://developers.google.com/identity/gsi/web/guides/migration
  3. Add sign-in/sign out from Google button somewhere so users can switch accounts
@randi-c-dubs
Copy link
Collaborator Author

randi-c-dubs commented Aug 29, 2022 •
edited

For #2, google-drive-picker google-drive-picker uses new auth flow. But 'Save Project to Google Drive' does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mewtaylor mewtaylor

@randi-c-dubs randi-c-dubs

@pmalacho-mit pmalacho-mit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mewtaylor @randi-c-dubs @pmalacho-mit