Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to use PPX on modules used by the unikernel.ml #1359

Open
dinosaure opened this issue Oct 3, 2022 · 2 comments
Open

Be able to use PPX on modules used by the unikernel.ml #1359

dinosaure opened this issue Oct 3, 2022 · 2 comments

Comments

@dinosaure
Copy link
Member

Currently, even if MirageOS 4 handles correctly PPX, they are only applied on duniverse/ projects. The idea is to put the ability to say that some of our files used by the unikernel.ml need PPX. That mostly mean that the end-user should be able, via the config.ml, to generate (preprocess (pps _)).
@TheLortex
Copy link
Member

TheLortex commented Oct 4, 2022 •
edited

Two solutions:

  • short term: in config.ml allow devices to extend the generated dune file with arbitrary content (or something specific for ppxs)
  • long term: let the user write unikernel.ml's dune file as a library providing the unikernel functor. This way, user has full control

dannywillems pushed a commit to dannywillems/opam-repository that referenced this issue Oct 4, 2022
@hannesm
[new release] mirage, mirage-runtime, functoria and functoria-runtime…
ee95da7 
… (4.3.0)

CHANGES:

#### Fixed

- The chamelon format example invocation had the arguments in the wrong order
  (mirage/mirage#1351, @hannesm)
- tar-mirage: allow the 2.x release series (mirage/mirage#1352, @hannesm)
- Fix the separator for list and pair combinator (command-line arguments, mirage/mirage#1354,
  @dinosaure, reported in mirage/mirage#1349 mirage/mirage#1348 by @rand00)
- Update references (hyperlinks) to erratique.ch documentation (mirage/mirage#1343, @reynir)

#### Changed

- Allow more log levels (None / quiet) (mirage/mirage#1275, @reynir, closes mirage/mirage#1273 & mirage/mirage#1274)
- Improve Functoria CLI: don't fail if context cache is invalid, handle
  situation when global arguments have a parse error (mirage/mirage#1359, @TheLortex)
- Remove v4 & v6 stack, and other deprecated bindings (mirage/mirage#1341, @hannesm)
- Remove FS remnants, and kv_ro of archive, and brittle shell scripts
  that used to generate FAT block storage devices (mirage/mirage#1353, @hannesm)
- Update to OCamlFormat 0.23.0 (mirage/mirage#1351, @dinosaure)
@kit-ty-kate
Copy link
Contributor

I like the long term solution a lot. That would also fix #1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dinosaure @TheLortex @kit-ty-kate