Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A documentation about mirage and mirage-skeleton #1336

Open
dinosaure opened this issue Jun 20, 2022 · 4 comments
Open

A documentation about mirage and mirage-skeleton #1336

dinosaure opened this issue Jun 20, 2022 · 4 comments

Comments

@dinosaure
Copy link
Member

Currently, the CI fails with this error:

opam-monorepo: [ERROR] Missing x-opam-monorepo-duniverse-dirs field in opam-monorepo lockfile ./mirage.opam.locked

But I'm not sure how to fix it.

@hannesm
Copy link
Member

hannesm commented Jun 20, 2022

Since I merged #1332 the mirage/mirage-skeleton#343 is required for mirage-skeleton... I'm not sure how the CI setup is supposed to be

In the past, the main branch of mirage-skeleton is supposed to work with the latest mirage release, and we used to have a dev branch in mirage-skeleton that'll work with mirage at the main branch.

But it seems, the current CI does something different, and assumes that mirage-skeleton at main works fine with mirage at main (and then I got surprised by #1332 (comment) -- so is there a way to specify for the CI to use a different branch of mirage-skeleton for mirage at main?

@hannesm
Copy link
Member

hannesm commented Jun 20, 2022

So, is there any documentation about the CI setup and how to cope with such scenarios (that mirage-skeleton needs some changes for mirage at main)?

@dinosaure
Copy link
Member Author

Hmmhmmm, ok I see. It seems that your PR on mirage-skeleton works with the current status of mirage/mirage. Let's merge it so. We should keep this issue and rename it by a proper documentation about the CI between mirage and mirage-skeleton.

@dinosaure dinosaure changed the title Issue about the generated *.locked file by opam-monorepo A documentation about mirage and mirage-skeleton Jun 20, 2022
@TheLortex
Copy link
Member

The current state is that mirage-skeleton#main is tested with mirage#main, since ocurrent/mirage-ci#19

Before that, mirage-skeleton#main was tested with the latest released version of mirage.

I think we should go back to this behavior, and add a dev branch to mirage-skeleton to test with mirage#main.
The dev branch should be synchronized to main when a new version of mirage is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants