We should not allow packages with a dot which leads a spurious solver error on the opam monorepo side
#1287
Comments
|
So it's fixed but I let the issue open. We probably need a message which explain why the package name is bad (and we should probably advise the user to use |
samoht
added a commit
to samoht/opam-repository
that referenced
this issue
Mar 27, 2022
… (4.0.0) CHANGES: #### Fixed - use `--solo5-abi=xen` for qubes target (mirage/mirage#1312, @hannesm) - Support using a different filename than `config.ml` with `-f` (mirage/mirage#1309, @dinosaure) - Fix build with dune 3.0 (mirage/mirage#1296, @dinosaure) - Check that the package name respects opam conventions (mirage/mirage#1287, mirage/mirage#1304, @TheLortex) - Allow to specify version of pinned packages (mirage/mirage#1295, @Julow) #### Changed - Use the same compilation as dune (mirage/mirage#1313, mirage/mirage#1316, mirage/mirage#1317, ,@samoht, @hannesm) - Require cmdliner 1.1 (mirage/mirage#1289, @samoht, @dinosaure, @dbuenzli) - Require opam 2.1 to use MirageOS (mirage/mirage#1239, 1311, @hannesm) - Require conduit 5.1 (mirage/mirage#1297, @hannesm) - Rename `ocaml-freestanding` to `ocaml-solo5` (mirage/mirage#1314, @dinosaure, @samoht, @hannesm) #### Added - Add Key.opt_all to allows usage of an argument multiple times (mirage/mirage#1292, mirage/mirage#1301, @dinosaure, @Drup) - Add Git devices (mirage/mirage#1291, @dinosaure, @samoht, @hannesm, @yomimono) - Add happy-eyeballs devices (mirage/mirage#1307, @dinosaure, @hannesm) - Add docteur device to manage read-only persistent key-value stores (mirage/mirage#1298, @dinosaure, @samoht) - Add tcpv4v6_of_stackv4v6 device (mirage/mirage#1293, @dinosaure) - Add int64 converter (mirage/mirage#1305, @dinosaure) - Add dns_client device (mirage/mirage#1302, mirage/mirage#1306, @dinosaure, @hannesm)
samoht
added a commit
to samoht/opam-repository
that referenced
this issue
Mar 28, 2022
… (4.0.0) CHANGES: #### Fixed - use `--solo5-abi=xen` for qubes target (mirage/mirage#1312, @hannesm) - Support using a different filename than `config.ml` with `-f` (mirage/mirage#1309, @dinosaure) - Fix build with dune 3.0 (mirage/mirage#1296, @dinosaure) - Check that the package name respects opam conventions (mirage/mirage#1287, mirage/mirage#1304, @TheLortex) - Allow to specify version of pinned packages (mirage/mirage#1295, @Julow) #### Changed - Use the same compilation as dune (mirage/mirage#1313, mirage/mirage#1316, mirage/mirage#1317, @samoht, @hannesm) - Remove unused `--warn-errors` and `--debug` flags (mirage/mirage#1320, @samoht) - Remove the deprecated `--target=ukvm` (mirage/mirage#1321, @hannesm) - Require cmdliner 1.1 (mirage/mirage#1289, @samoht, @dinosaure, @dbuenzli) - Require opam 2.1 to use MirageOS (mirage/mirage#1239, 1311, @hannesm) - Require conduit 5.1 (mirage/mirage#1297, @hannesm) - Rename `ocaml-freestanding` to `ocaml-solo5` (mirage/mirage#1314, @dinosaure, @samoht, @hannesm) #### Added - Add Key.opt_all to allows usage of an argument multiple times (mirage/mirage#1292, mirage/mirage#1301, @dinosaure, @Drup) - Add Git devices (mirage/mirage#1291, @dinosaure, @samoht, @hannesm, @yomimono) - Add happy-eyeballs devices (mirage/mirage#1307, @dinosaure, @hannesm) - Add docteur device to manage read-only persistent key-value stores (mirage/mirage#1298, @dinosaure, @samoht) - Add tcpv4v6_of_stackv4v6 device (mirage/mirage#1293, @dinosaure) - Add int64 converter (mirage/mirage#1305, @dinosaure) - Add dns_client device (mirage/mirage#1302, mirage/mirage#1306, @dinosaure, @hannesm)
samoht
added a commit
to samoht/opam-repository
that referenced
this issue
Mar 28, 2022
… (4.0.0) CHANGES: #### Fixed - use `--solo5-abi=xen` for qubes target (mirage/mirage#1312, @hannesm) - Support using a different filename than `config.ml` with `-f` (mirage/mirage#1309, @dinosaure) - Fix build with dune 3.0 (mirage/mirage#1296, @dinosaure) - Check that the package name respects opam conventions (mirage/mirage#1287, mirage/mirage#1304, @TheLortex) - Allow to specify version of pinned packages (mirage/mirage#1295, @Julow) #### Changed - Use the same compilation as dune (mirage/mirage#1313, mirage/mirage#1316, mirage/mirage#1317, @samoht, @hannesm) - Remove unused `--warn-errors` and `--debug` flags (mirage/mirage#1320, @samoht) - Remove the deprecated `--target=ukvm` (mirage/mirage#1321, @hannesm) - Require cmdliner 1.1 (mirage/mirage#1289, @samoht, @dinosaure, @dbuenzli) - Require opam 2.1 to use MirageOS (mirage/mirage#1239, 1311, @hannesm) - Require conduit 5.1 (mirage/mirage#1297, @hannesm) - Rename `ocaml-freestanding` to `ocaml-solo5` (mirage/mirage#1314, @dinosaure, @samoht, @hannesm) #### Added - Add Key.opt_all to allows usage of an argument multiple times (mirage/mirage#1292, mirage/mirage#1301, @dinosaure, @Drup) - Add Git devices (mirage/mirage#1291, @dinosaure, @samoht, @hannesm, @yomimono) - Add happy-eyeballs devices (mirage/mirage#1307, @dinosaure, @hannesm) - Add docteur device to manage read-only persistent key-value stores (mirage/mirage#1298, @dinosaure, @samoht) - Add tcpv4v6_of_stackv4v6 device (mirage/mirage#1293, @dinosaure) - Add int64 converter (mirage/mirage#1305, @dinosaure) - Add dns_client device (mirage/mirage#1302, mirage/mirage#1306, @dinosaure, @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We probably add a simple linter which checks that packages don't have dots in their names. I already get this error several times but it becomes hard to find it now where
opam monoreposilently tries to solve the malformed OPAM file. Related to tarides/opam-monorepo#255.The text was updated successfully, but these errors were encountered: