Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also generate mli files #1244

Open
samoht opened this issue Oct 19, 2021 · 2 comments
Open

Also generate mli files #1244

samoht opened this issue Oct 19, 2021 · 2 comments
Assignees
@dinosaure

Comments

@samoht
Copy link
Member

samoht commented Oct 19, 2021

We should try to generate mli files when possible to avoid this kind of warnings for generated code:

File "applications/crypto/key_gen.ml", line 1:
Warning 70 [missing-mli]: Cannot find interface file.
@dinosaure
Copy link
Member

We can use ocamlopt -i but I'm not sure that dune allows us to do that.

@dinosaure dinosaure mentioned this issue Feb 4, 2022
Closed
@dinosaure dinosaure added this to the mirage 4.0.0 milestone Feb 16, 2022
@samoht
Copy link
Member Author

samoht commented Mar 23, 2022 •
edited

This is clearly not blocking the 4.0 release (and maybe we should disable warning in the generated dune file).

@dinosaure dinosaure self-assigned this Mar 23, 2022
@hannesm hannesm removed this from the mirage 4.0.0 milestone Jun 20, 2023
@hannesm hannesm mentioned this issue Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinosaure dinosaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samoht @hannesm @dinosaure