Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix stack may raise in listen #513

Open
hannesm opened this issue Jan 16, 2024 · 1 comment
Open

unix stack may raise in listen #513

hannesm opened this issue Jan 16, 2024 · 1 comment

Comments

@hannesm
Copy link
Member

hannesm commented Jan 16, 2024

The Unix.bind in Tcpv4v6_socket is not guarded and may raise an exception. This leaks file descriptors, and the interface should be revised (or specified in a way that allows exceptions to occur).

Maybe a check in "connect" should be done if the IP address(es) are available at the moment (though obviously that may change during the operation of a unikernel.

Any ideas how to deal with that? Any networking unikernel were you specify dist/my-unikernel --ipv4=1.2.1.2/24 fails with an exeption (Unix.error EADDRNOTAVAIL) if 1.2.1.2 is not configured on the host.

@hannesm
Copy link
Member Author

hannesm commented Jan 17, 2024

reported here from the issue comment robur-coop/tlstunnel#13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant