Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry in readonly open #2122

Open
Ngoguey42 opened this issue Oct 19, 2022 · 0 comments
Open

Implement retry in readonly open #2122

Ngoguey42 opened this issue Oct 19, 2022 · 0 comments

Comments

@Ngoguey42
Copy link
Contributor

Since #2119 we are able to detect if a control file is being read with a data race. These data races can be solved by sleeping and retrying. We are however not capable of distinguishing between data races and corrupted control files, this implies that the number of retry should be bounded to fallback on a Corrupted_control_file error.

Also, since the GC finalisation deletes old files, a data race is possible if a RO instance stalls between the read the control file and the opening of the files. The data race would materialise as a No_such_file_or_directory error.

Both these data races could be fixed at once by implementing a retry in the file manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant