Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freyr freezes consistently on certain albums/songs in [Embedding Metadata] stage #642

Open
Flapperoo opened this issue Jan 17, 2024 · 9 comments

Comments

@Flapperoo
Copy link

Flapperoo commented Jan 17, 2024

Freyr would freeze at certain songs on certain albums on the Embedding Metadata stage. Results are consistent on my end

In this case:
Service: Deezer
Album: Kendrick Lamar - To Pimp A Butterfly
Song: 15. I

Audio-2024_01_16_10_53_PM.txt

Behavior exists on different albums but not all albums are affected.

@miraclx
Copy link
Owner

miraclx commented Jan 17, 2024

Can you include the full logs here in the issue?

Just put it inside this

<details>
<summary> Logs </summary>

```console
INSERT LOGS HERE
```

</details>

But are you saying, at the 15th track, it didn't even finish printing the track name? That seems like a serious issue

@miraclx
Copy link
Owner

miraclx commented Jan 17, 2024

All good?

@johnhelt
Copy link

johnhelt commented Jan 23, 2024

I have the same issue, but only when I run freyr inside the lidarr container from linuxserver, using lidarr extended from randomatkninja. The logs are simply:

   ____
   / __/_______  __  _______
  / /_/ ___/ _ \/ / / / ___/
 / __/ /  /  __/ /_/ / /
/_/ /_/   \___/\__, /_/
              /____/ v0.10.3

freyr - (c) Miraculous Owonubi <omiraculous@gmail.com>
------------------------------------------------------
Checking directory permissions...[done]
[deezer:album:52976202]
 [•] Identifying service...[Deezer]
 [•] Checking authentication...[authenticated]
 Detected [album]
 Obtaining album metadata...[done]
  ➤ Album Name: The Quality of Being One
  ➤ Artist: Saafi Brothers
  ➤ Tracks: 9
  ➤ Type: Album
  ➤ Year: 2017
 [•] Collating [The Quality of Being One]...
  [•] Inquiring tracks...[done]
   • [01 The Passage]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 2 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [02 Catch Me If You Can]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 2 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [04 Hippies in Trance]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 1 source]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [03 Joy of Mystery]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...(failed: [Zero sources found])
      |  ➤ [•] YouTube...(failed: [Zero sources found])
   • [05 Out on a Ride]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [06 Ta Tvam Asi]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [07 Dub No. 9]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 1 source]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [08 We Can Make It]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [09 Summer Travel (Gradual Transition Beatless Mix)]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...(failed: [Zero sources found])
      |  ➤ [•] YouTube...(failed: [Zero sources found])
 [•] Download Complete
 [•] Embedding Metadata...
  • [✓] 01 The Passage

then, nothing else. If I run freyr from wsl, it completes with this log:

    ____
   / __/_______  __  _______
  / /_/ ___/ _ \/ / / / ___/
 / __/ /  /  __/ /_/ / /
/_/ /_/   \___/\__, /_/
              /____/ v0.10.3

freyr - (c) Miraculous Owonubi <omiraculous@gmail.com>
------------------------------------------------------
[•] Initializing config file...[done]
Checking directory permissions...[done]
[deezer:album:52976202]
 [•] Identifying service...[Deezer]
 [•] Checking authentication...[authenticated]
 Detected [album]
 Obtaining album metadata...[done]
  ➤ Album Name: The Quality of Being One
  ➤ Artist: Saafi Brothers
  ➤ Tracks: 9
  ➤ Type: Album
  ➤ Year: 2017
 [•] Collating [The Quality of Being One]...
  [•] Inquiring tracks...[done]
   • [03 Joy of Mystery]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...(failed: [Zero sources found])
      |  ➤ [•] YouTube...(failed: [Zero sources found])
   • [04 Hippies in Trance]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 1 source]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [02 Catch Me If You Can]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 2 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | {⯈} @1{1/10}: (Request failed with status code 403) (      0/1596933)
      | {⯈} @7{1/10}: (Request failed with status code 403) (      0/1596937)
      | {⯈} @7{2/10}: (Request failed with status code 403) (      0/1596937)
      | {⯈} @7{3/10}: (Request failed with status code 403) (      0/1596937)
      | [✓] Got raw track file
      | [•] Post Processing...
   • [05 Out on a Ride]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [06 Ta Tvam Asi]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | {⯈} @6{1/10}: (Request failed with status code 403) (      0/1102403)
      | [✓] Got raw track file
      | [•] Post Processing...
   • [01 The Passage]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 2 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | {⯈} @1{1/10}: (Request failed with status code 403) (      0/1423329)
      | {⯈} @7{1/10}: (Request failed with status code 403) (      0/1423333)
      | [✓] Got raw track file
      | [•] Post Processing...
   • [07 Dub No. 9]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 1 source]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | {⯈} @2{1/10}: (Request failed with status code 403) (     0/817176)
      | {⯈} @1{1/10}: (Request failed with status code 403) (     0/817176)
      | {⯈} @2{2/10}: (Request failed with status code 403) (     0/817176)
      | [✓] Got raw track file
      | [•] Post Processing...
   • [08 We Can Make It]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...[success, found 3 sources]
      | ➤ Awaiting audiofeeds...[done]
      | [✓] Got album art
      | [✓] Got raw track file
      | [•] Post Processing...
   • [09 Summer Travel (Gradual Transition Beatless Mix)]
      | ➤ Collating sources...
      |  ➤ [•] YouTube Music...(failed: [Zero sources found])
      |  ➤ [•] YouTube...(failed: [Zero sources found])
 [•] Download Complete
 [•] Embedding Metadata...
  • [✓] 01 The Passage
  • [✓] 02 Catch Me If You Can
  • [✕] 03 Joy of Mystery [deezer:track:437900642] (failed: Failed collecting sources [Zero sources found])
  • [✓] 04 Hippies in Trance
  • [✓] 05 Out on a Ride
  • [✓] 06 Ta Tvam Asi
  • [✓] 07 Dub No. 9
  • [✓] 08 We Can Make It
  • [✕] 09 Summer Travel (Gradual Transition Beatless Mix) [deezer:track:437900702] (failed: Failed collecting sources [Zero sources found])
[•] Collation Complete
============ Stats ============
 [•] Runtime: [32.4s]
 [•] Total queries: [01]
 [•] Total tracks: [09]
     » Skipped: [00]
     ✓ Passed:  [07]
     ✕ Failed:  [02]
 [•] Output directory: [tmp]
 [•] Total Output size: 139.62 MB
 [•] Total Network Usage: 60.45 MB
     ♫ Media: 59.96 MB
     ➤ Album Art: 495.24 KB
 [•] Output bitrate: 320k
===============================

Is there a way to add more debug information while running freyr?

@miraclx
Copy link
Owner

miraclx commented Jan 23, 2024

Interesting, what happens when you download each song individually?

@miraclx miraclx reopened this Jan 23, 2024
@johnhelt
Copy link

johnhelt commented Jan 23, 2024

I'm not sure what the syntax is for that. I only have album id from deezer.
edit: I figured out how to get the track id.

update:
If I try to download the 2nd track of the album, which is the one that seems to be hanging wrt metadata, it still hangs:

freyr get deezer:track:437900632
    ____
   / __/_______  __  _______
  / /_/ ___/ _ \/ / / / ___/
 / __/ /  /  __/ /_/ / /
/_/ /_/   \___/\__, /_/
              /____/ v0.10.3

freyr - (c) Miraculous Owonubi <omiraculous@gmail.com>
------------------------------------------------------
Checking directory permissions...[done]
[deezer:track:437900632]
 [•] Identifying service...[Deezer]
 [•] Checking authentication...[authenticated]
 Detected [track]
 Obtaining track metadata...[done]
  ➤ Title: Catch Me If You Can
  ➤ Album: The Quality of Being One
  ➤ Artist: Saafi Brothers
  ➤ Year: 2017
  ➤ Playtime: 11:10
 [•] Collating...
 • [02 Catch Me If You Can]
    | ➤ Collating sources...
    |  ➤ [•] YouTube Music...[success, found 2 sources]
    | ➤ Awaiting audiofeeds...[done]
    | [✓] Got album art
    | [✓] Got raw track file
    | [•] Post Processing...
 [•] Download Complete
 [•] Embedding Metadata...


Maybe that helps narrowing down the issue?

@Flapperoo
Copy link
Author

Just want to add, I did further testing with this on the same setup as #642 (comment).

Manually running Freyr on the container (containing lidarr and randomatkninja's scripts) console works. It only freezes if Freyr was ran within the script context on my end. I have since moved on from the setup as it was unreliable for me.

@johnhelt
Copy link

With the risk of maybe going off topic, but for the sake of debugging, I'm interested, how did you run the container manually? I've done a /bash inside the running container with docker -it, but the issue is still there. The main user is root, so I don't think it could be related to user rights.

@Flapperoo
Copy link
Author

docker exec -it lidarr /bin/bash

I've just spun up a fresh container and ran Freyr on the docker console, I've found that it freezes on the first attempt, but subsequent attempts and the issue is gone. This is not, however, the same if Freyr was ran within the script context as it freezes everytime.

For reference, here's the command I used for Freyr which is basically the same as in randomatkninja's audio script:

freyr --no-bar --no-net-check -d /config/extended/downloads/audio/incomplete deezer:album:9896728

@johnhelt
Copy link

An update: if I log into the user with id 1000 in the lidarr container (user 'abc'), and run the same command freyr get deezer:track:437900632, the download completes and the metadata is applied. At the same time, if I try this as the default "root" user, the command fails as above. I've not been able to reproduce this in the freyr docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants