Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MusicBrainz as metadata source #321

Open
scottfridwin opened this issue Aug 20, 2022 · 2 comments · May be fixed by #361
Open

Support MusicBrainz as metadata source #321

scottfridwin opened this issue Aug 20, 2022 · 2 comments · May be fixed by #361
Labels
enhancement New feature or request

Comments

@scottfridwin
Copy link

Somewhat related to #81

If the api calls to connect with MusicBrainz are added in order to embed the metadata in the output file, would it be reasonable to also allow MusicBrainz ids as inputs? It gets a bit strange with the release vs. release-group distinction, but other than that I think it would be a fairly straightforward addition.

URL example: https://musicbrainz.org/release-group/082c6aff-a7cc-36e0-a960-35a578ecd937
Short URL example: mb:release-group:db92a151-1ac2-438b-bc43-b82e149ddd50

I have spare time and would be happy to help if this is a reasonable ask.
@miraclx
Copy link
Owner

miraclx commented Aug 20, 2022 •
edited

Ooh, this is slick. I, for one, certainly think this will be nice to have. I haven't looked into their API, but I think standardizing the URI might be a bit tricky.

If you feel you want to take this on, please, you're very much welcome to.

You can follow the patterns in https://github.com/miraclx/freyr-js/tree/master/src/services.

@ocococococ
Copy link

Oh yes, started PR seems promising.

@miraclx miraclx linked a pull request Jan 16, 2023 that will close this issue
Adding MusicBrainz as a metadata source #361
Draft
@miraclx miraclx added the enhancement New feature or request label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding MusicBrainz as a metadata source scottfridwin/freyr-js
3 participants
@miraclx @scottfridwin @ocococococ