fix: Upgrade azserect client for AZURE #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
force-pushed
the
upgrade_azserect_client
branch
from
5347da8
to
355dc13
Compare
jiuker
requested review from
harshavardhana,
aead,
donatello,
shtripat and
vadmeste
and removed request for
harshavardhana,
aead and
donatello
aead
requested changes
Jan 12, 2024
shtripat
reviewed
Jan 12, 2024
harshavardhana
requested changes
Jan 12, 2024
|
Hey @aead can you please review this when you get a chance? |
There was a problem hiding this comment.
Only minor comment, rest of them looks fine. We need to get rid of the old code @jiuker
jiuker
force-pushed
the
upgrade_azserect_client
branch
from
cf9f0dd
to
5a193b8
Compare
|
@jiuker did you get the chance to test this with Azure ? let me know if you need any help in Azure |
|
@aead we need to get this merged for a new kes release, so that we can move to a supported SDKs. Can you PTAL ? |
|
@aead can you please review this? |
harshavardhana
previously approved these changes
Feb 13, 2024
|
@aead we need to migrate to new SDK previous one is unmaintained now.. its a security risk. |
…client # Conflicts: # internal/keystore/azure/client.go
…ient # Conflicts: # go.mod # go.sum
|
Checking back again on this @aead let me know if you could look at this PR. |
|
#459 supersedes this PR, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade azserect client
How to test:
Once the verification is successful, I remove the redundant code
fix #261