Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CURLPART_ZONEID on building with an old version of CURL #14598

Closed
olafmustafar opened this issue Apr 27, 2024 · 2 comments · Fixed by #14615
Closed

Missing CURLPART_ZONEID on building with an old version of CURL #14598

olafmustafar opened this issue Apr 27, 2024 · 2 comments · Fixed by #14615
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does.
Milestone
5.9.0

Comments

@olafmustafar
Copy link

olafmustafar commented Apr 27, 2024 •
edited

Minetest version

master, on commit c63c05b
RUN_IN_PLACE=1
USE_CURL=1

Irrlicht device

SDL

Operating system and version

Debian Buster aarch64 (on qemu)

CPU model

No response

GPU model

No response

Active renderer

No response

Summary

If ENABLE_CURL is enabled, it looks for 7.28.0 version of curl, as stated in CMakeLists.txt:50
but in src/util/colorize.cpp:59 it looks for CURLUPART_ZONEID that is only present in version 7.65.0 (can be verified on https://curl.se/libcurl/c/curl_url_get.html)

This make compiling with the libcurl version 7.28.0 not work. We may update the required version of libcurl, or make so colorize.cpp doensn't use the CURLUPART_ZONEID.

Steps to reproduce

Compile minetest using a curl version older than 7.65.0 with ENABLE_CURL enabled
@olafmustafar olafmustafar added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Apr 27, 2024
@sfan5 sfan5 added Bug Issues that were confirmed to be a bug Blocker The issue needs to be addressed before the next release. Regression Something that used to work no longer does. and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Apr 27, 2024
@SmallJoker
Copy link
Member

Since 24cc33e, #13825

@Zughy Zughy added this to the 5.9.0 milestone Apr 28, 2024
@Zughy
Copy link
Member

Zughy commented Apr 28, 2024

@rubenwardy (unsubscribing)

@sfan5 sfan5 mentioned this issue May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does.
Projects
None yet
Milestone
5.9.0
Development

Successfully merging a pull request may close this issue.

Fix curl compatibility issues with colorize_url sfan5/minetest
4 participants
@sfan5 @SmallJoker @olafmustafar @Zughy