Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Restoring online skins for offline/cracked players #195

Open
unitythemaker opened this issue Apr 1, 2023 · 3 comments
Open

docs: Restoring online skins for offline/cracked players #195

unitythemaker opened this issue Apr 1, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request (not a bug) good first issue Good for newcomers help wanted Extra attention is needed priority/low Low priority task question Further information is requested

Comments

@unitythemaker
Copy link

Hey, we are trying to keep non-cracked users seeing skins. In BungeeCord servers, we used the SkinsRestorer plugin. We want to replace our BungeeCord with Gate, but I could not make the skins work. I tried installing SkinsRestorer on the spigot server but got the below file generated (I have enabled BungeeCord option in spigot.yml):

Screenshot from 2023-04-01 08-20-14

Screenshot of me with the default skin:
Screenshot from 2023-04-01 08-29-36

So, in this case, I can maybe try Gate Lite mode, but from my understanding, this would cause my AuthMe to save all users with the same IP address.

Maybe I understood something improperly, but it would be great if you could help!

@unitythemaker
Copy link
Author

Hmm, after joining the Discord server and reading the docs more carefully, I've got more information.
So the Lite mode does not lose the real IP but it does not support server switching. I need another proxy to do that. Maybe I can try to write an extension to achieve this without proxy chaining. I can try to write a Gate extension for SkinsRestorer.

If this is correct and if Gate won't add something like this built-in, I guess we can close that issue.

@robinbraemer
Copy link
Member

robinbraemer commented Apr 2, 2023

Hey @unitythemaker we can definitely work this out in an extension and you won’t need SkinsRestorer on spigot. You can change the skin textures in GameProfileRequestEvent https://gate.minekube.com/developers/events.html#available-events. This method applies the skin only once on login to the proxy.

@robinbraemer robinbraemer added enhancement New feature or request (not a bug) help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested priority/high High priority task labels Apr 2, 2023
@robinbraemer
Copy link
Member

We should prop add docs about it to the dev guide.

@robinbraemer robinbraemer added the documentation Improvements or additions to documentation label Apr 6, 2023
@robinbraemer robinbraemer changed the title restoring online skins for cracked docs: Restoring online skins for offline/cracked players Apr 6, 2023
@robinbraemer robinbraemer added priority/low Low priority task and removed priority/high High priority task labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request (not a bug) good first issue Good for newcomers help wanted Extra attention is needed priority/low Low priority task question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants