Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in loading scPerturb datasets #256

Open
abearab opened this issue Apr 30, 2024 · 3 comments
Open

bug in loading scPerturb datasets #256

abearab opened this issue Apr 30, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips

Comments

@abearab
Copy link
Contributor

abearab commented Apr 30, 2024

Hi @kexinhuang12345, as you know ReplogleWeissman2022 study has three datasets.

image

Currently, as I understand ReplogleWeissman2022_K562_gwps data is not uploaded. However, I noticed a weird behavior when I tried to load it! I had ReplogleWeissman2022_k562_essential already downloaded in a path folder and then I tried loading scperturb_gene_ReplogleWeissman2022_K562_gwps and noticed it's saying Found local copy...!

>>> test_load = PerturbOutcome('scperturb_gene_ReplogleWeissman2022_K562_gwps','Datasets')
Found local copy...
Loading...

Looking at the # of perturbations, it's not true for _gwps dataset. It should be 9867 but it's 2058 (this is the same number as _essential dataset)

>>> test_load.adata.obs.perturbation.unique()

Length: 2058

Looking more carefully, I tried an empty folder and noticed for some reason this is downloading wrong file for _gwps.

>>> test_load = PerturbOutcome('scperturb_gene_ReplogleWeissman2022_K562_gwps','Datasets/new/')
Downloading...
█████████████████████████████████████████████| 1.55G/1.55G [01:09<00:00, 22.2MiB/s]
Loading...
~: ls Datasets/new/

scperturb_gene_ReplogleWeissman2022_k562_essential.h5ad

cc @amva13

Originally posted by @abearab in #239 (comment)

@abearab
Copy link
Contributor Author

abearab commented May 20, 2024

@kexinhuang12345 – hi Kexin, I was wondering if you could check this issue. Thanks

@amva13 amva13 added bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips labels May 21, 2024
@kexinhuang12345
Copy link
Collaborator

Hi! Sorry for the delay - I think it is due to some name catching bugs, currently we do not have the gwps version uploaded to dataverse. Will fix it after the NeurIPS deadline!

@abearab
Copy link
Contributor Author

abearab commented May 21, 2024

Hi! Sorry for the delay - I think it is due to some name catching bugs, currently we do not have the gwps version uploaded to dataverse.

I see, that makes sense.

Will fix it after the NeurIPS deadline!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips
Projects
None yet
Development

No branches or pull requests

3 participants