Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: improve reduce performance on very large topk #32871

Merged
merged 1 commit into from May 13, 2024
Merged

enhance: improve reduce performance on very large topk #32871

merged 1 commit into from May 13, 2024

Conversation

xiaofan-luan
Copy link
Contributor

fix #32870
reduce cpu usage for reduce on large k

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels May 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (8a9a421) to head (0005af4).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32871      +/-   ##
==========================================
+ Coverage   82.07%   82.08%   +0.01%     
==========================================
  Files        1007     1007              
  Lines      127647   127647              
==========================================
+ Hits       104767   104780      +13     
+ Misses      18903    18895       -8     
+ Partials     3977     3972       -5
Files Coverage Δ
internal/proxy/search_reduce_util.go 84.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

@ThreadDao ThreadDao mentioned this pull request May 9, 2024
Open
1 task
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, Yherealtita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented May 11, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
enhance: improve reduce performance on very large topk
0005af4 
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 11, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 12, 2024
@czs007
Copy link
Contributor

czs007 commented May 13, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 230c88b into milvus-io:master May 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yherealtita Yherealtita Yherealtita approved these changes

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Map grow takes many proxy cpu on large topk
4 participants
@xiaofan-luan @sre-ci-robot @czs007 @Yherealtita