Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livereloadable react-router example #119

Open
milankinen opened this issue Jul 13, 2016 · 10 comments
Open

Add livereloadable react-router example #119

milankinen opened this issue Jul 13, 2016 · 10 comments

Comments

@milankinen
Copy link
Owner

Continuing from #43.

LiveReactLoads need an example for react-router (and perhaps also an example where both react-router and redux are being used). I'm gonna use @tukkajukka's excellent example project as a template (if it's ok?).

The example will be a part of the upcoming 2.3.0 release (please see #118).

@jukkatupamaki
Copy link

@milankinen Yes, that is totally ok!

@neemzy
Copy link

neemzy commented Aug 31, 2016

Hi,

Any news regarding this example? :)

Thanks!

@jukkatupamaki
Copy link

@neemzy I just updated my React template and it uses now Redux, React Router and Livereactload. You can find that here: https://github.com/lemanse/simple-react-app

@neemzy
Copy link

neemzy commented Sep 2, 2016

@tukkajukka Thanks a ton, but my project isn't using Redux, and I therefore can't use syncHistoryWithStore. I'd really love to see a working example without Redux!

@jukkatupamaki
Copy link

There's a version without Redux if you checkout an earlier commit: https://github.com/lemanse/simple-react-app/commit/108f298cdac25334dd5c4fb3c5031d593f1720f2

On 02 Sep 2016, at 17:47, Tom Panier notifications@github.com wrote:

@tukkajukka Thanks a ton, but my project isn't using Redux, and I therefore can't use syncHistoryWithStore. I'd really love to see a working example without Redux!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@neemzy
Copy link

neemzy commented Sep 5, 2016

Oh, right. I'll give it a try soon then :) Cheers! Feel free to close the issue if you want to.

@milankinen
Copy link
Owner Author

I've had no time to work with this yet. Sorry about that. I'll try to finish this as soon as I manage to get some time for my personal projects.

@neemzy
Copy link

neemzy commented Sep 5, 2016

No worries! Thanks :)

@neemzy
Copy link

neemzy commented Sep 14, 2016

I don't think this is really required anymore as the lib works seamlessly with react-router :)

@milankinen
Copy link
Owner Author

Nice to hear that! I think it's still good to have an example though, thus not closing this issue yet. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants