MikroOrm upgrade to v6 throws error Cannot read properties of undefined (reading 'values')

[DaleRest]

Describe the bug

upgrade from v4 to v5 and v6 and this issue is present in both v5 and v6. I have isolated to my imported modules. How can i further isolate to identify what is causing this?

For reference my appmodule
@Module({ controllers: [AppController], imports: [ ConfigModule.forRoot({ envFilePath: ['.env','.env.local','.env.deployment'], isGlobal: true, }), ConsoleModule, MikroOrmModule.forRoot(), ScheduleModule.forRoot(), SentryModule.forRootAsync({ imports: [SharedModule,ConfigModule], inject: [ConfigService], useFactory: async (configService: ConfigService) => ({ enabled: configService.get<boolean>("SENTRY_ENABLED"), dsn: configService.get<string>("SENTRY_DSN"), debug: configService.get<boolean>("SENTRY_DEBUG"), environment: configService.get<string>("NODE_ENV"), release: null, // must create a release in sentry.io dashboard logLevels: ['debug'] //LogLevel.Error, //based on sentry.io loglevel // }), }), BullModule.forRootAsync({ imports: [SharedModule, ConfigModule], useFactory: async (configService: ConfigService) => ({ redis: { host: configService.get<string>("REDIS_SERVER_HOST"), port: configService.get<number>("REDIS_SERVER_PORT"), db: configService.get<number>("REDIS_SERVER_DATABASE"), password: configService.get<string>("REDIS_SERVER_PASSWORD"), }, }), inject: [ConfigService], }), LoggerModule.forRootAsync({ inject: [ConfigService], useFactory: async (configService: ConfigService) => { return { pinoHttp: configService.get<any> ? { level: "debug", transport : { target: "pino-pretty", //new (after error resolve)refer here https://stackoverflow.com/questions/71649204/pinowarning-prettyprint-is-deprecated-look-at-https-github-com-pinojs-pino-p options:{ colorize: true, levelFirst: true, translateTime: "UTC:mm/dd/yyyy, h:MM:ss TT Z", }, } } : {}, }; }, imports: [ConfigModule], // providers: undefined }), AwsSdkModule.forRootAsync({ // TODO get rid off fallback env variables (added for correct work in local env) defaultServiceOptions: { useFactory: (configService: ConfigService) => ({ credentials: { accessKeyId: configService.get<string>("AWS_SDK_ACCESS_KEY") || configService.get<string>("MINIO_ACCESS_KEY"), secretAccessKey: configService.get<string>("AWS_SDK_SECRET_KEY") || configService.get<string>("MINIO_SECRET_KEY"), }, region: configService.get<string>("S3_STORAGE_REGION") || null, endpoint: configService.get<string>("S3_STORAGE_ENDPOINT_PRIVATE") || null, signatureVersion: "v4", s3ForcePathStyle: true, // false value not compatible with MinIO }), inject: [ConfigService], imports: [SharedModule,ConfigModule], }, }), paymentsModule, SlackUserModule, OrganisationModule, DashboardModule, NestAsyncEventModule, SharedModule, UsageStatsModule, UserModule, MailingModule, CategoryModule, AuthModule, PostModule, InboxModule, MessagingModule, NotificationModule, DataModule, ], providers: [ConfigService] }) export class AppModule { configure(consumer: MiddlewareConsumer) { consumer.apply(LogsMiddleware).forRoutes('*'); } }

And my authmodule:

@Module({ imports: [ JwtModule.registerAsync({ imports: [ConfigModule], inject: [ConfigService], useFactory: (configService: ConfigService) => ({ secretOrPrivateKey: configService.get<string>("JWT_SECRET_KEY"), signOptions: { expiresIn: configService.get<number>("JWT_EXPIRATION_TIME"), }, }), }), MikroOrmModule.forFeature({ entities: [...Object.values(moduleEntities), User] }), forwardRef(() => UserModule), // ConfigService, NestAsyncEventModule, PassportModule.register({ defaultStrategy: "jwt" }), ], providers: [AuthService, BannedByIpService, JwtStrategy, ConfigService], controllers: Object.values(authControllers), exports: [JwtStrategy, PassportModule, AuthService, BannedByIpService], }) export class AuthModule {}

Reproduction

upgrade from v4 to v5 and v6 and this issue is present in both v5 and v6. Once upgraded and you try and run the application, the application throws an error for entity discovery as per below:
[Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [MikroORM] [info] MikroORM version: 6.2.5 [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [MikroORM] [discovery] ORM entity discovery started, using TsMorphMetadataProvider [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] MikroOrmModule dependencies initialized +25ms [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] SentryModule dependencies initialized +1ms [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] PassportModule dependencies initialized +1ms [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] HttpModule dependencies initialized +4ms [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] HttpModule dependencies initialized +1ms [Nest] 30312 - 09/05/2024, 2:07:17 pm LOG [InstanceLoader] ConfigHostModule dependencies initialized +3ms [Nest] 30312 - 09/05/2024, 2:07:17 pm ERROR [ExceptionHandler] Cannot read properties of undefined (reading 'values') TypeError: Cannot read properties of undefined (reading 'values')

What driver are you using?

@mikro-orm/postgresql

MikroORM version

6

Node.js version

node.js version 20

Operating system

windows, linux

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

I need to see a reproduction, logs are not reproduction. Also the first step should be finding out the full stack trace as without it this error is not telling us anything.

Maybe look at this example project (which works just fine) and compare what you do differently.

https://github.com/mikro-orm/nestjs-realworld-example-app

And as usual, consult the upgrading guides in detail.

[B4nan]

You should report this to them, I cant help you with some 3rd party nest plugins.

[jdmevo123]

I have managed to identify this error, and now found what was causing it, this is the stack trace:

There is no duplicate fieldNames, and NewPostCommentNotification.post does not exist in the project at all. I have attached the entity file below the stack trace.

MetadataError: Duplicate fieldNames are not allowed: NewPostCommentNotification.post (fieldName: 'post_id'), NewPostCommentNotification.postId (fieldName: 'post_id')
    at Function.duplicateFieldName (api\services\node-app\node_modules\@mikro-orm\core\errors.js:182:16)
    at MetadataValidator.validateDuplicateFieldNames (api\services\node-app\node_modules\@mikro-orm\core\metadata\MetadataValidator.js:194:42)
    at MetadataValidator.validateEntityDefinition (api\services\node-app\node_modules\@mikro-orm\core\metadata\MetadataValidator.js:39:14)
    at MetadataDiscovery.processEntity (api\services\node-app\node_modules\@mikro-orm\core\metadata\MetadataDiscovery.js:457:24)
    at MetadataDiscovery.processDiscoveredEntities (api\services\node-app\node_modules\@mikro-orm\core\metadata\MetadataDiscovery.js:116:37)
    at MetadataDiscovery.discover (api\services\node-app\node_modules\@mikro-orm\core\metadata\MetadataDiscovery.js:47:14)
    at async MikroORM.discoverEntities (api\services\node-app\node_modules\@mikro-orm\core\MikroORM.js:172:25)
    at async Function.init (api\services\node-app\node_modules\@mikro-orm\core\MikroORM.js:44:9)
    at async Function.handleMigrationCommand (api\services\node-app\node_modules\@mikro-orm\cli\commands\MigrationCommandFactory.js:83:21) {
  entity: undefined
}

Entity File:

import { Cascade, Entity, ManyToOne, Property } from "@mikro-orm/core";
import { InboxNotification } from "./inbox-notification.entity";
import { InboxNotificationTypeEnum } from "../constants/enums";
import { User } from "../../user/entities";
import { PostComment } from "../../post/entities";

@Entity({ discriminatorValue: InboxNotificationTypeEnum.NEW_POST_COMMENT_NOTIFICATION })
export class NewPostCommentNotification extends InboxNotification {
  @Property()
  public readonly postId: number;

  @ManyToOne()
  public readonly to: User;

  @ManyToOne({ cascade: [Cascade.ALL], nullable: true })
  public readonly postComment: PostComment | null = null;

  constructor(to: User, postId: number, postComment?: PostComment) {
    super(InboxNotificationTypeEnum.NEW_POST_COMMENT_NOTIFICATION);

    this.postId = postId;
    this.to = to;
    this.postComment = postComment ?? null;
  }
}

[jdmevo123]

could this be a problem with packages?

I have tried deleting my migrations folder and recreating, but it throws the same error.

[B4nan]

It's a problem with your entity definition.

There is no duplicate fieldNames,

Yes, there are duplicates, the error explicitly mentions where. You are clearly defining two properties that map to the same column, you can't do that. Mark one of them as persist: false.

-@Property()
+@Property({ persist: false })
public readonly postId: number;

Note that you don't need this at all, feels like you are applying typeorm knowledge here. I would suggest you drop the postId property completely - you can read the value from post.id (and you don't need to populate it for it). I guess the post property lives in the parent class, but its surely there - the validation wouldn't kick in without the properties being defined.

[jdmevo123]

that worked perfectly thankyou for you help