Entity discovery on TsMorphMetadataProvider broken since 6.2.2

[sebastiaanviaene]

Describe the bug

I have the following orm config for entity discovery. Since 6.2.2 and specifically due to this commit it now fails to discover my ts entity files

const ormConfig = defineConfig({
  entities: ['dist/**/*.entity.js'],
  entitiesTs: ['src/**/*.entity.ts'],
 ...
});

The error I get:

MetadataError: Source file './dist/src/shared/entities/batch.entity.ts' not found. Check your 'entitiesTs' option and verify you have 'compilerOptions.declaration' enabled in your 'tsconfig.json'. If you are using webpack, see https://bit.ly/35pPDNn

when debugging I notice it's trying to translate ./dist/src/shared/entities/batch.entity.js to ./dist/src/shared/entities/batch.entity.ts but those are not in my sources array (because my source entities are not in dist ofcourse)

I found a work around but it's far from ideal. Notice the 2 different patterns due to __dirname being different for node / ts-node

const ormConfig = defineConfig({
  entities: ['**/*.entity.js', '../dist/**/*.entity.js'],
  entitiesTs: ['../../src/**/*.entity.ts', '**/*.entity.ts'],
  baseDir: path.resolve(__dirname),
  ...
  },
});

Reproduction

What driver are you using?

@mikro-orm/postgresql

MikroORM version

6.2.2

Node.js version

20.9.0

Operating system

MacOS

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

I need to see a reproduction, pointing to a problematic commit won't cut it.

cc @xmajzel

---

Note that this is almost always a bad idea, baseDir shouldn't be dynamic (which __dirname is).

baseDir: path.resolve(__dirname),

Or you say that's the workaround to get around this for you? Still, it rather points to a misconfiguration.

Also if you see paths like /dist/src its almost always wrong too. Or do you compile the whole src folder into dist?

[sebastiaanviaene]

Its a work around to make it work after 6.2.2

[sebastiaanviaene]

I do have src in my dist among other things