Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing alac with ffmpeg due to security issues #1478

Open
ehaupt opened this issue May 24, 2022 · 17 comments
Open

Consider replacing alac with ffmpeg due to security issues #1478

ehaupt opened this issue May 24, 2022 · 17 comments
Assignees

Comments

@ehaupt
Copy link

ehaupt commented May 24, 2022

alac has a long list of bugs and security issues. Please consider replacing it with ffmpeg.

This has been prompted by this FreeBSD issue.

@mikebrady
Copy link
Owner

Thanks for the suggestion and the information, Emanuel. As it happens Shairport Sync is just now capable of AirPlay 2 operation on FreeBSD and it is using an ffmpeg AAC decoder, so it should be possible to look at using the ffmpeg ALAC decoder. However, the size of the (libavcodec?) library may be an issue on smaller devices. Once the AirPlay 2 capability is released, I'll look into it.

@ehaupt
Copy link
Author

ehaupt commented May 24, 2022

Thank you @mikebrady! Maybe both, libavcodec and alac could be made optional (by configure argument). That would leave users and packagers a choice.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Stale label Jul 24, 2022
@ehaupt

This comment was marked as outdated.

@mikebrady mikebrady removed the Stale label Jul 24, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Stale label Sep 23, 2022
@m1m1s1ku

This comment was marked as outdated.

@github-actions github-actions bot removed the Stale label Sep 24, 2022
@ehaupt
Copy link
Author

ehaupt commented Nov 14, 2022

This repo seems to have source code fixed to at least some extent:

https://github.com/nu774/qaac/tree/master/ALAC
https://perkele.cc/software/ALAC

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the Stale label Jan 14, 2023
@ehaupt

This comment was marked as outdated.

@github-actions github-actions bot removed the Stale label Jan 15, 2023
@mikebrady
Copy link
Owner

Working (slowly) on stuff associated with this…

@github-actions github-actions bot added the Stale label Apr 26, 2023
@mikebrady mikebrady removed the Stale label Apr 26, 2023
Repository owner deleted a comment from github-actions bot Apr 26, 2023
@ehaupt

This comment was marked as duplicate.

@github-actions github-actions bot added the Stale label Jul 31, 2023
@ehaupt
Copy link
Author

ehaupt commented Jul 31, 2023

It is still relevant.

@mikebrady mikebrady removed the Stale label Jul 31, 2023
@mikebrady

This comment was marked as outdated.

Repository owner deleted a comment from github-actions bot Jul 31, 2023
@mikebrady

This comment was marked as outdated.

@mikebrady
Copy link
Owner

Still active!

This comment was marked as duplicate.

@github-actions github-actions bot added the Stale label Feb 21, 2024
Copy link

This issue has been inactive for 28 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

@github-actions github-actions bot added the Stale label May 22, 2024
@mikebrady mikebrady removed the Stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants