You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
emattias
changed the title
Wrong typing of collectionOp. options args is actually optional
Wrong typing of collectionOp and instanceOp. options args is actually optional
Oct 12, 2023
The options arg is typed to be required here: https://github.com/mike-north/ember-api-actions/blob/master/addon/utils/collection-action.ts#L16C25-L16C37
In the options arg all props are optional except
path
: https://github.com/mike-north/ember-api-actions/blob/master/addon/utils/collection-action.ts#L7-L14but
path
is sent tobuildOperationUrl
which fallsback tobaseUrl
when path is not provided: https://github.com/mike-north/ember-api-actions/blob/master/addon/utils/build-url.ts#L61-L63hence this line
should be changed to (just made
options
optional)And same thing with
instanceOp
The text was updated successfully, but these errors were encountered: