Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore three tests that only fail on Windows in CI #130

Open
mikaelvesavuori opened this issue Oct 9, 2021 · 0 comments
Open

Restore three tests that only fail on Windows in CI #130

mikaelvesavuori opened this issue Oct 9, 2021 · 0 comments
Labels
ci Continuous Integration technical-debt Technical debt
Projects
Figmagic

Comments

@mikaelvesavuori
Copy link
Owner

mikaelvesavuori commented Oct 9, 2021 •
edited

A small number of tests seem to fail exclusively on Windows CI builds:

  • getFileContentAndPath.test.ts
  • prepFile.test.ts
  • getSvgFileData.test.ts

This might have to do with CRLF or some similar "invisible" problems?

Successfully resolving this would make the tests accurately pass on all test platforms (Ubuntu, Windows...Mac?).
@mikaelvesavuori mikaelvesavuori created this issue from a note in Figmagic (In progress) Oct 9, 2021
@mikaelvesavuori mikaelvesavuori added the hacktoberfest Hacktoberfest label Oct 9, 2021
@mikaelvesavuori mikaelvesavuori changed the title FIX: Restore Windows testing in CI (3 weirdly failing tests?) CI: Restore Windows testing in CI (3 weirdly failing tests?) Oct 9, 2021
@mikaelvesavuori mikaelvesavuori changed the title CI: Restore Windows testing in CI (3 weirdly failing tests?) CI: Restore three tests that only fail on Windows in CI Oct 9, 2021
@mikaelvesavuori mikaelvesavuori added the ci Continuous Integration label Oct 9, 2021
@mikaelvesavuori mikaelvesavuori changed the title CI: Restore three tests that only fail on Windows in CI Restore three tests that only fail on Windows in CI Oct 9, 2021
@mikaelvesavuori mikaelvesavuori removed the hacktoberfest Hacktoberfest label Nov 8, 2021
@mikaelvesavuori mikaelvesavuori moved this from In progress to To do in Figmagic Mar 28, 2022
@mikaelvesavuori mikaelvesavuori added the technical-debt Technical debt label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous Integration technical-debt Technical debt
Projects
Figmagic
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikaelvesavuori