Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images in elements #127

Open
mikaelvesavuori opened this issue Oct 9, 2021 · 2 comments
Open

Support images in elements #127

mikaelvesavuori opened this issue Oct 9, 2021 · 2 comments
Labels
enhancement New feature or request
Projects

Comments

@mikaelvesavuori
Copy link
Owner

Currently, when generating elements (i.e. "React components"), images are not supported.

Example: If you were to generate a button with a background-image, the generation would attempt to understand the general CSS properties but bypass the image.

I assume that an implementation of this would result in a background-image property to be generated. It would also be necessary to download the image and ensure that one is correctly pointing to it.

@mikaelvesavuori mikaelvesavuori created this issue from a note in Figmagic (In progress) Oct 9, 2021
@mikaelvesavuori mikaelvesavuori added hacktoberfest Hacktoberfest enhancement New feature or request labels Oct 9, 2021
@mikaelvesavuori mikaelvesavuori changed the title FEATURE: Support images in elements Support images in elements Oct 9, 2021
@mikaelvesavuori mikaelvesavuori removed the hacktoberfest Hacktoberfest label Nov 8, 2021
@glouhaichi
Copy link

@mikaelvesavuori is this the same issue as elements not referencing icons (graphics) they were built with in Figma? For example, we have buttons with leading and trailing icons, and these icons are configured as graphics that are pulling correctly using Figmagic. However, the imported button elements are not referencing said graphics in the generated React component.

@mikaelvesavuori
Copy link
Owner Author

Almost. This issue is about images as defined in CSS. Your issue is about supporting image references in elements, if I am not mistaken. Both of these cases are currently not supported.

@mikaelvesavuori mikaelvesavuori moved this from In progress to To do in Figmagic Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Figmagic
  
To do
Development

No branches or pull requests

2 participants