Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant checking for key value #19

Open
swpalmer opened this issue Sep 24, 2019 · 0 comments
Open

Redundant checking for key value #19

swpalmer opened this issue Sep 24, 2019 · 0 comments

Comments

@swpalmer
Copy link

if(key >= connections.size() || connections[key] == NULL) {

There are two checks if the key value is too large, and a check if the connection is null. Only the second 'if' appears to be relevant. Was this the result of a bad merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant