HTTPS: Fix PUT resume #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 17 17
Lines 1075 1076 +1
=======================================
+ Hits 1042 1043 +1
Misses 33 33
Continue to review full report at Codecov.
|
|
Will stop pursuing this, since a server-side WebDAV config supporting PUT ranges is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUT resume was tested with 2 files: 1st file was put and then the 2nd one.
Since they had the same name, the upload was resumed.
This, however, does not guarantee that a full resume is possible, since getting the problem lies in the getting of the already uploaded bytes.
EDIT: Consider using
POSTto rewrite the file entirely (no resume possible).Fixes: #57.