Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of liquid and any other confusing irrelevant library from the docs #1196

Open
ohcibi opened this issue Jul 2, 2021 · 0 comments

Comments

@ohcibi
Copy link

ohcibi commented Jul 2, 2021

My colleague just asked me if he needed to install liquid because he wants to use tabs, I wtf'ed as response and as it turns out he had that strange idea from this very page: https://miguelcobain.github.io/ember-paper/#/components/tabs where apparently every example is implemented using liquid.

  1. there is absolutely no point in using liquid in a documentation. Best thing that can happen is that the reader is only confused. It might be worth to add such info to the cookbooks, but
  2. liquid is outdated!
  3. The documentation is more than confusing because liquid completely hides what needs to be done to make the connection of tab and tab body work. Also the example just makes no sense as it uses the very same tab body for all tabs

My suggestion is to use a simplyfied version of that very page as an example as it has tabs with different tab body content. But without the liquid fire part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant