New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using the concat protocol (for MPEG TS) #1968
Comments
Hard to say. Sometimes merging some files simply doesn't work due to limitation in the ffmpeg concat implentation. you could check FAQ and try to disable tracks and see if it makes a difference |
Thank you for answer. Meanwhile I have gained some clues. First, I noticed the issue occurs in VLC Media Player, but does not occur in Windows Media Player. Second, when I make trimming and concatenating by ffmpeg (from command line), the issue does not occur, I mean VLC plays it properly (at least flickering is much shorter if at all and I don't feel any audio shift). |
If you managed to losslessly concatenate using ffmpeg directly, mind to share which commands that produced a correct results? |
Certainly, though I am sure you know them if I know them :) Without analyzing / comparing of the videos the commands probably will not be much of a help. I used this command for a few concatenating operations and got good results: I was happy with it until yesterday when concatenated three videos with the above command and from the weld between second and third one I got audio shift :( I am a novice about ffpmeg, just try what I find in Internet, so if you have any suggestions (switches) I could try just let me know here and I will be testing them. |
This looks very similar to what losslesscut is already doing. So i'm not sure why it's working from the command line but not from losslesscut. PS losslesscut prints out the commands that it has run. "Tools -> last ffmpeg commands"
interesting. this is the concat protocol, it is very simple in that it just concatenates the raw file data without demuxing (it's like simply concatenating the binary data of the files together). therefore it only works for some formats like MPEGTS which doesn't have any header at the beginning of the file. |
Thank you for your tips. They are really helpful. I made some more research and it looks you are absolutely right about the command
The output generated by LosslessCut and ffmpeg is the same ("FC: no differences encountered"). The source of the issue with flickering and audio shift lays before merging. It lays during cut operation. This is my first conclusion. The second is that when I used
command to concatenate the same two files the output comes with the flickering issue, but without audio shift issue. I wonder if "seek keyframe" function in LosslessCut applies at MPEGTS files, because when I use
command to trim video defining fractions of a second it looks to cut precisely at that point without seeking and shifting back or forth to any keyframe. Does the TS format have keyframes? Am I able to definitely know if a file has keyframes? |
yes it does
they should show up as dark lines on the timeline when you enable the keyframes button in losslesscut. it's hard to say what's the problem exactly. it often take some experimenting to get the right output when losslessly cutting/merging. |
A few updates.
I can do it very precisely, probably with accuracy to a single frame.
works better. It still sometimes flickers at the weld on VLC, but no audio shift. At least for now.
That's all for now. |
Ok so to summarize, you'd like to be able to use the concat protocol instead of the concat demuxer which losslesscut currently uses. e.g. I will leave this as a feature request. |
For me it is less important, because I can do it purely by ffmpeg for the operations I am performing at the moment (trimming tv streams and merging some of them). However for many people using commands in command prompt is quite a big challenge. Maybe adding a radio button giving them 2 options (concat demuxer, concat protocol as you described them) with short proper floating description just for MPEGTS files would be good idea. |
The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first
Steps to reproduce
I trim 2 files (using only "seek keyframe"), they play fine after that. Then I open first trimmed file, then open the other one, a dialog box appears, I choose "Merge/concatenate with current file", "check compatability" ok, merge operation is completed successfully, it plays fine until it comes to the point where the files were merged. The video flickers for a second and from that moment the audio is shifted a little bit.
I make many this kind of operations (trimming + merging) with the same kind of files and this is second or third time I experience the problem. Could you take a look what could be wrong? The files are quite big (2x 350MB + merged 700MB), I am not sure if I can upload them here.
Expected behavior
After merge the resulting file should play fine.
Actual behavior
The video flickers for a second and audio is shifted from that point.
Provide an error report
No error message.
Share the file
No response
Share log from developer tools
No response
The text was updated successfully, but these errors were encountered: