unresolve comment does not move focus to it

[meganrogge]

1. resolve a comment
2. use the context menu action, unresolve comment in the comment panel
3. expected: focus of the comment, actual: focus doesn't move to the comment

Unsure if this is by design, but would be nice if it focused the comment at least when in screen reader mode.

[meganrogge]

Screen.Recording.2024-04-10.at.11.17.48.AM.mov

[alexr00]

Not intentional and inconsistent with the way other trees work.

[alexr00]

I can't actually repro that the comment thread in the tree view doesn't get focus:

1. Put focus in the editor
2. Right click on a comment thread in the comments view
3. "Unresolve" from the context menu
4. The comment thread in the tree view gets focus.

Is this what you're seeing @meganrogge?

[meganrogge]

I am not focusing the editor first.

1. right click on a comment thread in the comments view
2. resolve conversation
3. scroll away
4. right click on the comment thread in the comments view
5. unresolve
6. 🐛 it doesn't scroll that comment into view

[alexr00]

I think this behavior is correct. When a tree is taken, the focus should remain in the tree.

[meganrogge]

I agree the focus should remain in the tree. I had just expected the comment widget that was unresolved to be revealed.

Feel free to close though if you think this is working as designed.

[alexr00]

I get it now: reveal the comment in the editor, not focus it.

This is interesting. Is it just the "unresolve" action that you would expect to reveal the comment in the editor? I'm thinking there are some actions it makes sense to reveal for, and some that it doesn't.

[meganrogge]

I am not sure which other actions you are thinking of. But I think since a user is unresolving the comment, it implies they might take an action on it, so revealing makes sense IMO.

[alexr00]

The actions are from extensions, so it could be anything. I was trying to decide if this should be implemented for all actions that are contributed to the comments view or just some. I'm thinking just some, which means this should be done in the extension.