Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koi8ru and koi8t file encodings are not supported on Windows #12272

Open
Colengms opened this issue May 1, 2024 · 0 comments
Open

koi8ru and koi8t file encodings are not supported on Windows #12272

Colengms opened this issue May 1, 2024 · 0 comments
Labels
bug Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@Colengms
Copy link
Collaborator

Colengms commented May 1, 2024

VS Code uses iconv for translating file encodings. (Actually https://github.com/microsoft/vscode-iconv-lite-umd ).

Files provided to extensions by VS Code are first converted to UTF-8. But,. for files that cpptools needs to open directly from disk (unopen header files), it needs to deal with encodings directly (i.e. to render doc comments correctly).

Cpptools uses iconv on Linux and Mac, but on Windows it currently uses Win32 APIs. There are 2 encodings explicitly supported by VS Code that are not supported by Win32 APIs:

  • koi8ru - The nearest equivalent is 20866 (koi8-r), but is missing Belarusian.
  • koi8-t - There is no equivalent code page, so no support available on Windows.

This could be addressed by using iconv on Windows as well.

@Colengms Colengms added bug Language Service world ready An issue relating string character encodings, localization translations, etc. labels May 1, 2024
@Colengms Colengms added this to the Backlog milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
None yet
Development

No branches or pull requests

1 participant