Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3[dbstat] doesn't enable dbstat actually. #38700

Closed
veawor opened this issue May 12, 2024 · 1 comment · Fixed by #38711
Closed

sqlite3[dbstat] doesn't enable dbstat actually. #38700

veawor opened this issue May 12, 2024 · 1 comment · Fixed by #38711
Assignees
@MonicaLiu0311
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@veawor
Copy link

veawor commented May 12, 2024

Describe the bug
After vcpkg.exe install sqlite3[dbstat] , use sqlite3_compileoption_used("SQLITE_ENABLE_DBSTAT_VTAB") to test if the feature is built-in. However, the function returns false.

Environment

  • OS: Windows
  • Compiler: Microsoft Visual C++ 2022

To Reproduce

  1. vcpkg.exe install sqlite3[dbstat]
  2. Use sqlite3_compileoption_used("SQLITE_ENABLE_DBSTAT_VTAB") to test if return true.

Expected behavior
sqlite3_compileoption_used("SQLITE_ENABLE_DBSTAT_VTAB") shall return true.

Failure logs
N/A

Additional context
N/A
@Osyotr
Copy link
Contributor

Osyotr commented May 12, 2024 •
edited

#30432 missed crucial change in the configuration header
https://github.com/microsoft/vcpkg/blob/master/ports/sqlite3/sqlite3-vcpkg-config.h.in

@MonicaLiu0311 MonicaLiu0311 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels May 13, 2024
@MonicaLiu0311 MonicaLiu0311 mentioned this issue May 13, 2024
Merged
7 tasks
data-queue pushed a commit that referenced this issue May 14, 2024
@MonicaLiu0311
[sqlite3] Fix feature dbstat (#38711)
c30bf9d 
Fixes #38700. Enable the sqlite3 feature `dbstat` and let
`SQLITE_ENABLE_DBSTAT_VTAB` return `TRUE`:



![image](https://github.com/microsoft/vcpkg/assets/110024546/cfd99f66-c652-4761-82a9-81c91a36b0cc)


- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sqlite3] Fix feature dbstat MonicaLiu0311/vcpkg
3 participants
@Osyotr @veawor @MonicaLiu0311