{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":100060912,"defaultBranch":"main","name":"terminal","ownerLogin":"microsoft","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-08-11T18:38:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6154722?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715204110.0","currentOid":""},"activityList":{"items":[{"before":"d967c6fb661eb7da5a4af503ee53b30cd6f2fc43","after":"d964874d1cbe6111ed6cce72324e4afafc51367d","ref":"refs/heads/feature/llm","pushedAt":"2024-05-09T01:34:11.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"miniksa","name":"Michael Niksa","path":"/miniksa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18221333?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/main' into feature/llm","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/main' into feature/llm"}},{"before":"db16f655a966de0b6393d6303bc9a310896726d4","after":null,"ref":"refs/heads/dev/lhecker/tsf-fixup","pushedAt":"2024-05-08T21:35:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"}},{"before":"49e4eea60f737b46b8aeda505f4693df8a9d44a6","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-17213-dbac3a1fa3755737be0d761e6e44e86b58e2865e","pushedAt":"2024-05-08T21:35:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"dbac3a1fa3755737be0d761e6e44e86b58e2865e","after":"49e4eea60f737b46b8aeda505f4693df8a9d44a6","ref":"refs/heads/main","pushedAt":"2024-05-08T21:35:09.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix typing multiple emojis on Windows 10 (#17213)\n\nOn Windows 10 Emojis don't finish composition until the Emoji picker\npanel is closed. Each emoji is thus its own composition range.\n`firstRange` thus caused only the first emoji to finish composition.\nThe end result was that all remaining emojis would stay around\nforever, with the user entirely unable to clear them.\n\n## Validation Steps Performed\n* Windows 10 VM\n* Open Emoji picker (Win+.)\n* Press and hold Enter on any Emoji\n* Press Esc to finish the composition\n* All of the Emoji can be backspaced / deleted","shortMessageHtmlLink":"Fix typing multiple emojis on Windows 10 (#17213)"}},{"before":"3e222ea774ea30cf1c32132919d3ae907755a059","after":null,"ref":"refs/heads/dev/lhecker/17206-persistence-fixup","pushedAt":"2024-05-08T21:31:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"}},{"before":"dbac3a1fa3755737be0d761e6e44e86b58e2865e","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-17211-0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","pushedAt":"2024-05-08T21:31:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","after":"dbac3a1fa3755737be0d761e6e44e86b58e2865e","ref":"refs/heads/main","pushedAt":"2024-05-08T21:31:20.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix session being persisted even when disabled (#17211)\n\nThis fixes 2 bugs:\n* `PersistState` being called when the window is closed\n (as opposed to closing the tab). The settings check was missing.\n* Session cleanup running depending on whether the feature is\n currently enabled as opposed to whether it was enabled on launch.\n\nCloses #17206\nCloses #17207\n\n## Validation Steps Performed\n* Create a bunch of leftover buffer_*.txt files by running\n the current Dev version off of main\n* Build this branch, then open and close a window\n* All buffer_*.txt are gone and state.json is cleaned up ✅","shortMessageHtmlLink":"Fix session being persisted even when disabled (#17211)"}},{"before":"4c219ff7ddc94ae5e1cb3b354dffb1ac25c10695","after":null,"ref":"refs/heads/dev/lhecker/17204-noflushonend","pushedAt":"2024-05-08T21:01:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlos-zamora","name":"Carlos Zamora","path":"/carlos-zamora","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11050425?s=80&v=4"}},{"before":"0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-17212-6d0342f0bb31bf245843411c6781d6d5399ff651","pushedAt":"2024-05-08T21:01:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"6d0342f0bb31bf245843411c6781d6d5399ff651","after":"0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","ref":"refs/heads/main","pushedAt":"2024-05-08T21:01:58.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix !_noFlushOnEnd not flushing (#17212)\n\nThis simply copies a bit more from `VtEngine::EndPaint`'s\n`_noFlushOnEnd` handling which already seems to fix the linked issue.\n\nCloses #17204","shortMessageHtmlLink":"Fix !_noFlushOnEnd not flushing (#17212)"}},{"before":null,"after":"49e4eea60f737b46b8aeda505f4693df8a9d44a6","ref":"refs/heads/gh-readonly-queue/main/pr-17213-dbac3a1fa3755737be0d761e6e44e86b58e2865e","pushedAt":"2024-05-08T20:58:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix typing multiple emojis on Windows 10 (#17213)\n\nOn Windows 10 Emojis don't finish composition until the Emoji picker\npanel is closed. Each emoji is thus its own composition range.\n`firstRange` thus caused only the first emoji to finish composition.\nThe end result was that all remaining emojis would stay around\nforever, with the user entirely unable to clear them.\n\n## Validation Steps Performed\n* Windows 10 VM\n* Open Emoji picker (Win+.)\n* Press and hold Enter on any Emoji\n* Press Esc to finish the composition\n* All of the Emoji can be backspaced / deleted","shortMessageHtmlLink":"Fix typing multiple emojis on Windows 10 (#17213)"}},{"before":null,"after":"dbac3a1fa3755737be0d761e6e44e86b58e2865e","ref":"refs/heads/gh-readonly-queue/main/pr-17211-0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","pushedAt":"2024-05-08T20:53:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix session being persisted even when disabled (#17211)\n\nThis fixes 2 bugs:\n* `PersistState` being called when the window is closed\n (as opposed to closing the tab). The settings check was missing.\n* Session cleanup running depending on whether the feature is\n currently enabled as opposed to whether it was enabled on launch.\n\nCloses #17206\nCloses #17207\n\n## Validation Steps Performed\n* Create a bunch of leftover buffer_*.txt files by running\n the current Dev version off of main\n* Build this branch, then open and close a window\n* All buffer_*.txt are gone and state.json is cleaned up ✅","shortMessageHtmlLink":"Fix session being persisted even when disabled (#17211)"}},{"before":null,"after":"6d42250ac7989cf819f9abb06877f0bb4eed6fd6","ref":"refs/heads/dev/duhowett/esrp-subtask","pushedAt":"2024-05-08T20:50:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"build: move ESRP to a parameterized subtask which takes signingId\n\nThis centralized all our ESRP calls in one file, which will make it\neasier in the future when we are invariable required to change how we\ncall it again.","shortMessageHtmlLink":"build: move ESRP to a parameterized subtask which takes signingId"}},{"before":null,"after":"0b76c51ba10c81ba4213ba98cf88f2abdf91b15e","ref":"refs/heads/gh-readonly-queue/main/pr-17212-6d0342f0bb31bf245843411c6781d6d5399ff651","pushedAt":"2024-05-08T20:24:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix !_noFlushOnEnd not flushing (#17212)\n\nThis simply copies a bit more from `VtEngine::EndPaint`'s\n`_noFlushOnEnd` handling which already seems to fix the linked issue.\n\nCloses #17204","shortMessageHtmlLink":"Fix !_noFlushOnEnd not flushing (#17212)"}},{"before":"f50de59f8776e022322bb0901a3604566d9a7c5d","after":"db16f655a966de0b6393d6303bc9a310896726d4","ref":"refs/heads/dev/lhecker/tsf-fixup","pushedAt":"2024-05-08T20:21:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Even betterer","shortMessageHtmlLink":"Even betterer"}},{"before":"d19f395131ec44e18477d6f6c869ab012c27fd44","after":"f50de59f8776e022322bb0901a3604566d9a7c5d","ref":"refs/heads/dev/lhecker/tsf-fixup","pushedAt":"2024-05-08T20:18:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Even better","shortMessageHtmlLink":"Even better"}},{"before":"37af51763b0148ad3d7dcf1ac1ed21b4a7312183","after":"33cd4b666ffe9e49880e4c1281d08bc6b305e2d6","ref":"refs/heads/dev/cazamor/spec/quick-fix","pushedAt":"2024-05-08T20:14:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlos-zamora","name":"Carlos Zamora","path":"/carlos-zamora","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11050425?s=80&v=4"},"commit":{"message":"spellcheck","shortMessageHtmlLink":"spellcheck"}},{"before":"7d00b25fbf6f52b0207eb8df27b9358cef256a87","after":"d4d216ca3395a26529ecadb0c73472c108baadcf","ref":"refs/heads/dev/pabhoj/command_keys","pushedAt":"2024-05-08T17:48:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PankajBhojwani","name":null,"path":"/PankajBhojwani","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26824113?s=80&v=4"},"commit":{"message":"don't need helper anymore","shortMessageHtmlLink":"don't need helper anymore"}},{"before":"ba375ec2a250e9ded990a590e5c9c7a028a45bb3","after":"7d00b25fbf6f52b0207eb8df27b9358cef256a87","ref":"refs/heads/dev/pabhoj/command_keys","pushedAt":"2024-05-08T17:12:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PankajBhojwani","name":null,"path":"/PankajBhojwani","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26824113?s=80&v=4"},"commit":{"message":"spelling","shortMessageHtmlLink":"spelling"}},{"before":null,"after":"ba375ec2a250e9ded990a590e5c9c7a028a45bb3","ref":"refs/heads/dev/pabhoj/command_keys","pushedAt":"2024-05-08T17:01:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"PankajBhojwani","name":null,"path":"/PankajBhojwani","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26824113?s=80&v=4"},"commit":{"message":"remove keys from command","shortMessageHtmlLink":"remove keys from command"}},{"before":"ee4c59636483d0b88c404ab000e089b253315860","after":"37af51763b0148ad3d7dcf1ac1ed21b4a7312183","ref":"refs/heads/dev/cazamor/spec/quick-fix","pushedAt":"2024-05-08T16:58:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlos-zamora","name":"Carlos Zamora","path":"/carlos-zamora","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11050425?s=80&v=4"},"commit":{"message":"add some future considerations (and other feedback)","shortMessageHtmlLink":"add some future considerations (and other feedback)"}},{"before":"d5be49fb459fc83799b5b2f38d7f3c728ed4f665","after":"bdd0f64370e7b67c79be9609b8b3c68c90b9430b","ref":"refs/heads/dev/duhowett/fhl-2024/merge-idls","pushedAt":"2024-05-08T16:09:26.000Z","pushType":"push","commitsCount":54,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/main' into dev/duhowett/fhl-2024/merge-idls","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/main' into dev/duhowett/fhl-2024…"}},{"before":null,"after":"d19f395131ec44e18477d6f6c869ab012c27fd44","ref":"refs/heads/dev/lhecker/tsf-fixup","pushedAt":"2024-05-08T15:08:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix typing multiple emojis on Windows 10","shortMessageHtmlLink":"Fix typing multiple emojis on Windows 10"}},{"before":null,"after":"4c219ff7ddc94ae5e1cb3b354dffb1ac25c10695","ref":"refs/heads/dev/lhecker/17204-noflushonend","pushedAt":"2024-05-08T14:00:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix !_noFlushOnEnd not flushing","shortMessageHtmlLink":"Fix !_noFlushOnEnd not flushing"}},{"before":"070b06943ca7865032be5bdc8cf3b89c016b253f","after":"3e222ea774ea30cf1c32132919d3ae907755a059","ref":"refs/heads/dev/lhecker/17206-persistence-fixup","pushedAt":"2024-05-08T13:48:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix session being persisted even when disabled","shortMessageHtmlLink":"Fix session being persisted even when disabled"}},{"before":null,"after":"070b06943ca7865032be5bdc8cf3b89c016b253f","ref":"refs/heads/dev/lhecker/17206-persistence-fixup","pushedAt":"2024-05-08T13:44:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"},"commit":{"message":"Fix session being persisted even when disabled","shortMessageHtmlLink":"Fix session being persisted even when disabled"}},{"before":"d4f0a32fc38574e8c1f8e85405ae544ba91965d2","after":"d967c6fb661eb7da5a4af503ee53b30cd6f2fc43","ref":"refs/heads/feature/llm","pushedAt":"2024-05-08T01:31:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"miniksa","name":"Michael Niksa","path":"/miniksa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18221333?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/main' into feature/llm","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/main' into feature/llm"}},{"before":"e349130d4e744a9d9d908f4fea4bb4749e40efbb","after":"0cc5194def65b749f6660e7246a485f505736d29","ref":"refs/heads/release-1.20","pushedAt":"2024-05-07T22:15:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Add nullptr checks to shared_ptr conversions (#17199)\n\nWe use `if (auto self = weakSelf.get())` in a lot of places.\nThat assigns the value to `self` and then checks if it's truthy.\nSometimes we need to add a \"is (app) closing\" check because XAML,\nso we wrote something akin to `if (self = ...; !closing)`.\n\nBut that's wrong because the correct `if (foo)` is the same as\n`if (void; foo)` and not `if (foo; void)` and that meant that\nwe didn't check for `self`'s truthiness anymore.\n\nThis issue became apparent now, because we added a new kind of\ndelayed callback invocation (which is a lot cheaper).\nThis made the lack of a `nullptr` check finally obvious.\n\n(cherry picked from commit 6d0342f0bb31bf245843411c6781d6d5399ff651)\nService-Card-Id: 92509287\nService-Version: 1.20","shortMessageHtmlLink":"Add nullptr checks to shared_ptr conversions (#17199)"}},{"before":"f0fc1b570193aff5ff97707178156ff0a6aefcb7","after":"1f54562f04e248f4a4172d23e5c4e1f0c62c5d72","ref":"refs/heads/release-1.21","pushedAt":"2024-05-07T22:15:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DHowett","name":"Dustin L. Howett","path":"/DHowett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/189190?s=80&v=4"},"commit":{"message":"Add nullptr checks to shared_ptr conversions (#17199)\n\nWe use `if (auto self = weakSelf.get())` in a lot of places.\nThat assigns the value to `self` and then checks if it's truthy.\nSometimes we need to add a \"is (app) closing\" check because XAML,\nso we wrote something akin to `if (self = ...; !closing)`.\n\nBut that's wrong because the correct `if (foo)` is the same as\n`if (void; foo)` and not `if (foo; void)` and that meant that\nwe didn't check for `self`'s truthiness anymore.\n\nThis issue became apparent now, because we added a new kind of\ndelayed callback invocation (which is a lot cheaper).\nThis made the lack of a `nullptr` check finally obvious.\n\n(cherry picked from commit 6d0342f0bb31bf245843411c6781d6d5399ff651)\nService-Card-Id: 92509288\nService-Version: 1.21","shortMessageHtmlLink":"Add nullptr checks to shared_ptr conversions (#17199)"}},{"before":"fa0a8bebd97ab52ad9a28f3e4acc4c82ca0eb3fc","after":null,"ref":"refs/heads/dev/lhecker/crash-fix","pushedAt":"2024-05-07T19:14:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"lhecker","name":"Leonard Hecker","path":"/lhecker","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2256941?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERSyeXAA","startCursor":null,"endCursor":null}},"title":"Activity · microsoft/terminal"}