Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher Tools: Evaluate results is incorrect when evaluate criteria has negative number parameters #5659

Open
v-katherine opened this issue May 9, 2024 · 1 comment

Comments

@v-katherine
Copy link

Describe the bug
Teacher Tools: Evaluate results is incorrect when evaluate criteria has negative number parameters

Steps to reproduce the behavior
1.Navigate to MakeCode Teacher Tool (microbit.org).
2.Open a checklist, enter Project Link or Share ID and submit.
3.Open a checklist and change the number in numeric parameter as negative number.
4.Click Evaluate button and observe the results.

Actual behavior:
The result shows 'Look Good' even though the number is negative number.

Expected behavior:
Cannot evaluate the numeric parameters criteria.

Screen Recording:
resultswrong

Additional context:
1.OS: Windows11, iMac Ventura 13.6.6
2.makecode.microbit,org version: 7.0.9
3.Microsoft MakeCode version: 10.0.21

@v-katherine
Copy link
Author

This bug also reproduced when input 0 in the numeric parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant