Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending CartesianChartVisualizationObject with more properties #122

Open
danbohus opened this issue Apr 6, 2021 · 0 comments
Open

Extending CartesianChartVisualizationObject with more properties #122

danbohus opened this issue Apr 6, 2021 · 0 comments
Labels
help wanted Issues identified as good community contribution opportunities

Comments

@danbohus
Copy link
Contributor

danbohus commented Apr 6, 2021

(this issue was created based on issue #120)

The CartesianChartVisualizationObject from Microsoft.Psi.LiveCharts.Visualization leverages LiveCharts to visualize chart data. The initial implementation of this visualization object we have provided does not yet expose all the properties that the underlying charting technology has. As one example, the LiveCharts documentation available here indicates that one should be able to set the axis min and max values. There are a number of other unexposed properties as well of the underlying Axis, for instance FontFamily, FontSize, FontWeight, LabelsRotation, etc., on the Chart itself, on the underlying Axis.Separator object, etc. More information on the various available properties can be found in the livecharts documentation and also in the LiveCharts GitHub repository.

We would like to extend the CartesianChartVisualizationObject to expose these properties and thus make them user-editable when using this visualizer from Platform for Situated Intelligence studio. An example of the pattern used to expose these properties is given by the currently-exposed AxisXTitle, AxisYTitle and DisableAnimations properties. A corresponding property needs to be created in the CartesianChartVisualizationObject.cs and the necessary bindings need to be constructed in the CartesianChartVisualizationObjectView.xaml -- see for instance the bindings to the AxisXTitle, AxisYTitle and DisableAnimations.

This issue represents a good community contribution opportunity, and is labeled 'help-wanted'. If you decide you would like to develop this feature and contribute it to the codebase, we would be happy to consider/review a pull request. If you have further questions, please post them below. To avoid duplication of work, if you start working on this with the goal of creating a pull request, please mention this by replying to this issue.

@danbohus danbohus added the help wanted Issues identified as good community contribution opportunities label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

1 participant