New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download-BcNuGetPackageToFolder - download all dependency versions issued after wanted "version release" filter #3353
Comments
Have re-formatted your issue to be readable. |
Can it be the .nuspec of Microsoft.Application and Microsoft.BaseApplication which wrong "version release" on the dependencies specified? Let me know if I can assist with something? |
In general with Business Central apps, you can only specify the version you depend on and then your app is supposed to work with all versions higher than that. Obviously, we know that this isn't true, but that is the only thing you can specify in app.json.
and regenerate Microsoft apps into a different feed (at first): MSApps2 and MSSymbols2 with a DependencyVersionTemplate set to:
will fairly quickly return:
Which is the expected result. Note, that if you do not specify the -version - it will still be very inefficient. I will investigate how this can be fixed. |
Thanks, I agree that this fix on New-BcNuGetPackage with control of dependencyVersionTemplate must be able to solve the problem. It matches my own conclusion of wrong dependencies in the .nuspec. I will test on the new Artifacts Feeds: MSApps2 and MSSymbols2. I get back to you if I find any issues. I wish you a nice and well-earned vacation |
PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
I am test the new NuGet features trying to find/get/download NuGet Packages through Azure DevOps Artifacts. This is where I realized that something is wrong if it is not the lastest BC you want.
I am upstreaming from dynamicssmb2/DynamicsBCPublicFeeds/MSSymbols. And, was basically just wanted to download eg. latest version 22 og Microsoft.BaseAppplication.DK.symbols/Microsoft.Application.DK in the following cases:
-FAILS on Microsoft.SystemApplication downloaded 23.4 doesn't match installed version 22.0
-LOOP all later version starting from the latest 23.4 build, Downloads this, drops it and append to excludestring, trying all previous builds until the one that works (took me 40 min. to get to the right version) and now I have like 200 versions of the Microsoft.SystemAppplication.symbols downloaded in my own Artifacts feed. Is this the correct behaviour? Couldn't we skip the download of the package when searching for a match?
Find-BcNuGetPackage and Get-BcNuGetPackage works fine.
BUT, resolving dependencies on Download-BcNuGetPackageToFolder as failed or gone into a very long loop (looping through all later versions of each dependency, than the wanted version.
Idea, "Version Filter" from is not aligned for MS Application dependencies!
Method called:
Output
Method called:
Output
AND SO IT CONTINUES
Screenshots
From my Artifacts feed - and there are a lot more versions....
Additional context
I have tried to remove "installedPlatform" from my call - it does not fail, but are these the expected downloads? Something is really wrong!
Results in following end of output:
Package successfully downloaded
Publisher Name id Version
Microsoft Application 22.5.59966.63441
Microsoft System Application 63ca2fa4-4f03-4f2b-a480-172fef340d3f 23.4.15643.16126
Microsoft Base Application 437dbf0e-84ff-417a-965d-ed2bb9650972 23.4.15643.16126
The text was updated successfully, but these errors were encountered: