Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not support --napa_binding_binary_host_mirror #259

Open
smildlzj opened this issue Sep 6, 2018 · 0 comments
Open

not support --napa_binding_binary_host_mirror #259

smildlzj opened this issue Sep 6, 2018 · 0 comments

Comments

@smildlzj
Copy link

smildlzj commented Sep 6, 2018

hi,
my .npmrc as fllow

napa_binding_binary_host_mirror=http://xxx.com/mirrors/xxxxxxxxxxxx/

but,when npm install,it can't read this setting.
so i read the source of node-pre-gyp, in lib/util/versioning.js

var host = process.env['npm_config_' + opts.module_name + '_binary_host_mirror'] || package_json.binary.host;

in napajs's package.json, this module_name is napa-binding, but in process.env is 'napa_binding'

so it cant override package.json mirror setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant