ListView doesn't handle NotifyCollectionChangedAction.Replace with different number of items in old and new.

[euju-ms]

Describe the bug

When a ListView databinds to a collection that implements INotifyCollectionChanged, and the collection invokes a CollectionChanged event with NotifyCollectionChangedAction.Replace with different number of items in newItems and oldItems, the ListView does not update.

I uploaded a simple test app here: https://github.com/euju-ms/CollectionChangedReplaceBug

Essentially, when my testCollection gains an item, it fires a replace event
E.g. [A, B] => [A, B, C]

In this case, ListView should update its visual from showing A, B to showing A, B, C, but it doesn't change in visual at all.
Replace event with same number of items in newItems and oldItems seem to work fine.

`
public void AddByReplace(string new Item)
{
_list.Add(newItem); // _list is a List.

CollectionChanged?.Invoke(this, new NotifyCollectionChangedEventArgs(
    NotifyCollectionChangedAction.Replace,
    _list.ToArray(),
    _list.GetRange(0, _list.Count - 1),
    0));

}
`

<ListView Header="TestCollection" ItemsSource="{x:Bind testCollection, Mode=OneWay}" ItemTemplate="{StaticResource StringDataTemplate}" /> <!-- StringDataTemplate is just a TextBlock -->

I couldn't find any restriction on "Replace" CollectionChanged event needing to have the same number of items in newItems and oldItems, so I'm filing this as a bug here.

E.g. NotifyCollectionChangedEventArgs constructor for Replace does not check for the number of items.

Steps to reproduce the bug

1. Get the source code from https://github.com/euju-ms/CollectionChangedReplaceBug
2. Run the application from VisualStudio as a packaged app.
3. Click on the button with Replace (2->3)
4. Notice that items on the left don't change (below TestCollection).

Expected behavior

Items on the left (below "TestCollection") should change whenever "Replace (2->3)" button is clicked.

Screenshots

On startup:

Clicking "Replace (2 -> 3)"
Actual:

Expected result is that you see three items below TestCollection, "hello", "world", "New Text 0".

NuGet package version

None

Windows version

No response

Additional context

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

• ListView reorder items doesn't trigger VectorChanged with winrt (#8748), similarity score: 0.73

Closed similar issues:

• ItemsRepeater with NonVirtualizingLayout doesn't react to Replace action on ItemsSource (#6614), similarity score: 0.76
• Bug: TreeView - using IObservableVector.ReplaceAll to update ItemsSource does not work (#1379), similarity score: 0.73
• ObservableCollection binding not working for UWP (#3816), similarity score: 0.71
• [Preview-4] winui Listview control not binding to observable collection within UWP app (#4216), similarity score: 0.71

Note: You can give me feedback by thumbs upping or thumbs downing this comment.